Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'origin' metadata to python dependencies #564

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jul 28, 2023

While I don't think we should discriminate between dependency types for general use, this is useful metadata in some contexts and is easy to include.

@cottsay cottsay added the enhancement New feature or request label Jul 28, 2023
@cottsay cottsay self-assigned this Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4a70c62) 81.93% compared to head (35d591f) 81.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          65       65           
  Lines        3753     3753           
  Branches      724      724           
=======================================
  Hits         3075     3075           
  Misses        622      622           
  Partials       56       56           
Files Changed Coverage Δ
colcon_core/package_augmentation/python.py 90.24% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever name is chosen (including as is) I'm good with the change.

colcon_core/package_augmentation/python.py Outdated Show resolved Hide resolved
While I don't think we should discriminate between dependency origins for
general use, this is useful metadata in some contexts and is easy to
include.
@cottsay cottsay changed the title Add 'type' metadata to python dependencies Add 'origin' metadata to python dependencies Aug 22, 2023
@cottsay cottsay merged commit c8995e3 into master Aug 22, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/dep-types branch August 22, 2023 21:23
@cottsay cottsay added this to the 0.13.0 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants