Consistency fixes for test_executor_sequential #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A things things here: 1. Use a real Job object like the other test. The sequential executor doesn't seem to need it to have a 'identifier' property, but other executors do and we should be consistent. 2. Move stuff out of the try/finally block for the os.kill thread to reduce the likelihood of secondary exceptions. 3. Clear the global job accumulation variable even though we don't use check it (which is another conversation entirely).
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 62 62
Lines 3648 3648
Branches 705 705
=======================================
Hits 2987 2987
Misses 609 609
Partials 52 52 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
Motivation behind this change is to port this test to
colcon-parallel-executor.