Extract generic decorator into a reusable class #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only current use of the decorator pattern in colcon-core is the argument parser, but the concept can be applied generically in a variety of scenarios.
cottsay
force-pushed
the
cottsay/generic-decorator
branch
from
4a799e4
to
c7c65fc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 81.88% 81.92% +0.04%
==========================================
Files 62 63 +1
Lines 3648 3657 +9
Branches 705 707 +2
==========================================
+ Hits 2987 2996 +9
Misses 609 609
Partials 52 52
☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only current use of the decorator pattern in colcon-core is the argument parser, but the concept can be applied generically in a variety of scenarios.
Motivation for this change is to implement the decorator pattern in the new standards-based Python extensions.