Track dependency categories on recursive dependencies #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 81.90% 81.93% +0.03%
==========================================
Files 65 65
Lines 3746 3753 +7
Branches 722 724 +2
==========================================
+ Hits 3068 3075 +7
Misses 622 622
Partials 56 56
☔ View full report in Codecov by Sentry. |
|
Yes please! Thanks for working on this. |
cottsay
force-pushed
the
cottsay/dep-categories
branch
3 times, most recently
from
158a676
to
fb04d02
Compare
nuclearsandwich
approved these changes
Aug 17, 2023
When enumerating the recursive dependencies for a package descriptor, track which dependency categories the dependency appears to be a part of. This information can be used later to drop certain dependencies or inform a developer of the context around a relationship. Note that the category list is not merged when a dependency appears multiple times in a package's tree, and the most shallow instance prevails.
cottsay
force-pushed
the
cottsay/dep-categories
branch
from
fb04d02
to
99f7a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enumerating the recursive dependencies for a package descriptor, track which dependency categories the dependency appears to be a part of. This information can be used later to drop certain dependencies or inform a developer of the context around a relationship.