Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target platforms for debs #588

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Update target platforms for debs #588

merged 1 commit into from
Oct 2, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 2, 2023

  • Bionic is in ESM and does not package importlib-metadata
  • Buster does not package importlib-metadata
  • Stretch has Python 3.5 and hasn't been support for a long time now
  • Bookworm is the current "stable" Debian

When this change is merged into colcon-core, I'm going to make the same change in the other colcon packages without review, since it will effectively be a cherry-pick.

* Bionic is in ESM and does not package importlib-metadata
* Buster does not package importlib-metadata
* Stretch has Python 3.5 and hasn't been support for a long time now
* Bookworm is the current "stable" Debian
@cottsay cottsay self-assigned this Oct 2, 2023
@cottsay cottsay linked an issue Oct 2, 2023 that may be closed by this pull request
@cottsay cottsay added this to the 0.15.0 milestone Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2ce42f1) 83.32% compared to head (587bab8) 83.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files          65       65           
  Lines        3760     3760           
  Branches      725      725           
=======================================
  Hits         3133     3133           
  Misses        551      551           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit f2c3296 into master Oct 2, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/deb-targets branch October 2, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

colcon-core 0.13.1python3.8 dependency breaks ROS 2 Dashing
2 participants