Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed osc.js Ports should fire an error event if a user attempts to send messages with them #58

Closed
colinbdclark opened this issue May 20, 2016 · 1 comment
Closed

Closed osc.js Ports should fire an error event if a user attempts to send messages with them #58

colinbdclark opened this issue May 20, 2016 · 1 comment
Milestone
2.1.0

Comments

@colinbdclark
Copy link
Owner

Currently, it appears that a osc.Port object doesn't consistently fire an error event when a user tries to send messages on it without having previously opened the Port. A call to send() on a closed Port currently appears to succeed, but has no effect. This is an easy coding error to make, and osc.js should be more explicit in noting it.
This was referenced May 20, 2016
Closed
Closed
@colinbdclark
Copy link
Owner Author

UDPPorts, of course, are the exception to this, since the socket need not be open for receiving messages in order to send them.

colinbdclark added a commit that referenced this issue May 25, 2016
@colinbdclark
Merge branch 'gh-58'
7ad1d47 
* gh-58:
  Fixes gh-58: Fires error events when sending on a closed port. Factors WebSocketPort into separate cross-platform file.
@colinbdclark colinbdclark added this to the 2.1.0 milestone May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@colinbdclark