Fix regression from getSelectCountSql optimization when collection us…

…es bind parameters in join clauses. Refs OpenMage#2210
colinmollenhour · May 26, 2023 · 1830dd8 · 1830dd8
1 parent e3c88f1
commit 1830dd8
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/lib/Varien/Data/Collection/Db.php b/lib/Varien/Data/Collection/Db.php
@@ -240,8 +240,11 @@ public function getSelectCountSql()
         } else {
             $countSelect->columns('COUNT(*)');
 
-            // Simple optimization - remove all joins if there are no where clauses using joined tables and all joins are left joins
-            $leftJoins = array_filter($countSelect->getPart(Zend_Db_Select::FROM), function ($table) {
+            // Simple optimization - remove all joins if:
+            // - there are no where clauses using joined tables
+            // - all joins are left joins
+            // - there are no join conditions using bind params (for simplicity)
+            $leftJoins = array_filter($countSelect->getPart(Zend_Db_Select::FROM), function($table) {
                 return ($table['joinType'] == Zend_Db_Select::LEFT_JOIN || $table['joinType'] == Zend_Db_Select::FROM);
             });
             if (count($leftJoins) == count($countSelect->getPart(Zend_Db_Select::FROM))) {
@@ -258,7 +261,13 @@ public function getSelectCountSql()
                         return !preg_match($pattern, $clause);
                     });
                 });
-                if (empty($whereUsingJoin)) {
+                if ($this->_bindParams) {
+                    $bindPattern = '/('.implode('|', array_keys($this->_bindParams)).')/';
+                    $joinUsingBind = array_filter($leftJoins, function ($table) use ($bindPattern) {
+                        return preg_match($bindPattern, $table['joinCondition']);
+                    });
+                }
+                if (empty($whereUsingJoin) && empty($joinUsingBind)) {
                     $from = array_slice($leftJoins, 0, 1);
                     $countSelect->setPart(Zend_Db_Select::FROM, $from);
                 }