prefer int to uint t

throws exception. PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#601 dotnet/efcore#11597
collinbarrett · Aug 29, 2018 · 17525e1 · 17525e1
1 parent 9b9c2d0
commit 17525e1
Show file tree

Hide file tree

Showing 31 changed files with 47 additions and 47 deletions.
diff --git a/src/FilterLists.Api/V1/Controllers/ListsController.cs b/src/FilterLists.Api/V1/Controllers/ListsController.cs
@@ -30,7 +30,7 @@ public async Task<IActionResult> GetById(int id) =>
             Json(await MemoryCache.GetOrCreate("ListsController_GetById_" + id, entry =>
             {
                 entry.AbsoluteExpirationRelativeToNow = FourHoursFromNow;
-                return filterListService.GetDetailsAsync((uint)id);
+                return filterListService.GetDetailsAsync(id);
             }));
 
         [HttpGet("seed")]

diff --git a/src/FilterLists.Data/Entities/BaseEntity.cs b/src/FilterLists.Data/Entities/BaseEntity.cs
@@ -4,7 +4,7 @@ namespace FilterLists.Data.Entities
 {
     public abstract class BaseEntity : IBaseEntity
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public DateTime? CreatedDateUtc { get; set; }
         public DateTime? ModifiedDateUtc { get; set; }
     }

diff --git a/src/FilterLists.Data/Entities/FilterList.cs b/src/FilterLists.Data/Entities/FilterList.cs
@@ -20,7 +20,7 @@ public class FilterList : BaseEntity
         public string HomeUrl { get; set; }
         public string IssuesUrl { get; set; }
         public ICollection<FilterListLanguage> FilterListLanguages { get; set; }
-        public uint? LicenseId { get; set; }
+        public int? LicenseId { get; set; }
         public License License { get; set; }
         public ICollection<FilterListMaintainer> FilterListMaintainers { get; set; }
         public ICollection<Merge> MergeFilterLists { get; set; }
@@ -30,7 +30,7 @@ public class FilterList : BaseEntity
         public DateTime? PublishedDate { get; set; }
         public ICollection<Snapshot> Snapshots { get; set; }
         public string SubmissionUrl { get; set; }
-        public uint? SyntaxId { get; set; }
+        public int? SyntaxId { get; set; }
         public Syntax Syntax { get; set; }
         public ICollection<FilterListTag> FilterListTags { get; set; }
         public string ViewUrl { get; set; }

diff --git a/src/FilterLists.Data/Entities/Junctions/FilterListLanguage.cs b/src/FilterLists.Data/Entities/Junctions/FilterListLanguage.cs
@@ -2,9 +2,9 @@
 {
     public class FilterListLanguage : BaseJunctionEntity
     {
-        public uint FilterListId { get; set; }
+        public int FilterListId { get; set; }
         public FilterList FilterList { get; set; }
-        public uint LanguageId { get; set; }
+        public int LanguageId { get; set; }
         public Language Language { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/FilterListMaintainer.cs b/src/FilterLists.Data/Entities/Junctions/FilterListMaintainer.cs
@@ -2,9 +2,9 @@
 {
     public class FilterListMaintainer : BaseJunctionEntity
     {
-        public uint FilterListId { get; set; }
+        public int FilterListId { get; set; }
         public FilterList FilterList { get; set; }
-        public uint MaintainerId { get; set; }
+        public int MaintainerId { get; set; }
         public Maintainer Maintainer { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/FilterListTag.cs b/src/FilterLists.Data/Entities/Junctions/FilterListTag.cs
@@ -2,9 +2,9 @@
 {
     public class FilterListTag : BaseJunctionEntity
     {
-        public uint FilterListId { get; set; }
+        public int FilterListId { get; set; }
         public FilterList FilterList { get; set; }
-        public uint TagId { get; set; }
+        public int TagId { get; set; }
         public Tag Tag { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/Fork.cs b/src/FilterLists.Data/Entities/Junctions/Fork.cs
@@ -2,9 +2,9 @@
 {
     public class Fork : BaseJunctionEntity
     {
-        public uint ForkFilterListId { get; set; }
+        public int ForkFilterListId { get; set; }
         public FilterList ForkFilterList { get; set; }
-        public uint UpstreamFilterListId { get; set; }
+        public int UpstreamFilterListId { get; set; }
         public FilterList UpstreamFilterList { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/Merge.cs b/src/FilterLists.Data/Entities/Junctions/Merge.cs
@@ -2,9 +2,9 @@
 {
     public class Merge : BaseJunctionEntity
     {
-        public uint MergeFilterListId { get; set; }
+        public int MergeFilterListId { get; set; }
         public FilterList MergeFilterList { get; set; }
-        public uint UpstreamFilterListId { get; set; }
+        public int UpstreamFilterListId { get; set; }
         public FilterList UpstreamFilterList { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/SnapshotRule.cs b/src/FilterLists.Data/Entities/Junctions/SnapshotRule.cs
@@ -2,9 +2,9 @@
 {
     public class SnapshotRule : BaseJunctionEntity
     {
-        public uint SnapshotId { get; set; }
+        public int SnapshotId { get; set; }
         public Snapshot Snapshot { get; set; }
-        public uint RuleId { get; set; }
+        public int RuleId { get; set; }
         public Rule Rule { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Junctions/SoftwareSyntax.cs b/src/FilterLists.Data/Entities/Junctions/SoftwareSyntax.cs
@@ -2,9 +2,9 @@
 {
     public class SoftwareSyntax : BaseJunctionEntity
     {
-        public uint SoftwareId { get; set; }
+        public int SoftwareId { get; set; }
         public Software Software { get; set; }
-        public uint SyntaxId { get; set; }
+        public int SyntaxId { get; set; }
         public Syntax Syntax { get; set; }
     }
 }
diff --git a/src/FilterLists.Data/Entities/Snapshot.cs b/src/FilterLists.Data/Entities/Snapshot.cs
@@ -6,7 +6,7 @@ namespace FilterLists.Data.Entities
 {
     public class Snapshot : BaseEntity
     {
-        public uint FilterListId { get; set; }
+        public int FilterListId { get; set; }
         public FilterList FilterList { get; set; }
         public int? HttpStatusCode { get; set; }
         public bool WasSuccessful { get; set; }

diff --git a/src/FilterLists.Data/EntityTypeConfigurations/FilterListTypeConfiguration.cs b/src/FilterLists.Data/EntityTypeConfigurations/FilterListTypeConfiguration.cs
@@ -31,7 +31,7 @@ public override void Configure(EntityTypeBuilder<FilterList> entityTypeBuilder)
             entityTypeBuilder.Property(x => x.IssuesUrl)
                              .HasColumnType("TEXT");
             entityTypeBuilder.Property(x => x.LicenseId)
-                             .HasDefaultValue((uint)5)
+                             .HasDefaultValue(5)
                              .IsRequired();
             entityTypeBuilder.Property(x => x.Name)
                              .HasColumnType("VARCHAR(126)")

diff --git a/src/FilterLists.Services/FilterList/FilterListService.cs b/src/FilterLists.Services/FilterList/FilterListService.cs
@@ -21,7 +21,7 @@ public FilterListService(FilterListsDbContext dbContext, IConfigurationProvider
         public async Task<IEnumerable<ListSummaryDto>> GetAllSummariesAsync() =>
             await DbContext.FilterLists.OrderBy(l => l.Name.ToLower()).ProjectTo<ListSummaryDto>(MapConfig).ToListAsync();
 
-        public async Task<ListDetailsDto> GetDetailsAsync(uint id) =>
+        public async Task<ListDetailsDto> GetDetailsAsync(int id) =>
             await DbContext.FilterLists.ProjectTo<ListDetailsDto>(MapConfig)
                            .FirstOrDefaultAsync(x => x.Id == id)
                            .FilterParentListFromMaintainerAdditionalLists();

diff --git a/src/FilterLists.Services/FilterList/Models/ListDetailsDto.cs b/src/FilterLists.Services/FilterList/Models/ListDetailsDto.cs
@@ -7,7 +7,7 @@ namespace FilterLists.Services.FilterList.Models
     [UsedImplicitly]
     public class ListDetailsDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string ChatUrl { get; set; }
         public string Description { get; set; }
         public string DescriptionSourceUrl { get; set; }

diff --git a/src/FilterLists.Services/FilterList/Models/ListMaintainerDto.cs b/src/FilterLists.Services/FilterList/Models/ListMaintainerDto.cs
@@ -6,7 +6,7 @@ namespace FilterLists.Services.FilterList.Models
     [UsedImplicitly]
     public class ListMaintainerDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string EmailAddress { get; set; }
         public string HomeUrl { get; set; }
         public string Name { get; set; }

diff --git a/src/FilterLists.Services/FilterList/Models/ListSummaryDto.cs b/src/FilterLists.Services/FilterList/Models/ListSummaryDto.cs
@@ -7,7 +7,7 @@ namespace FilterLists.Services.FilterList.Models
     [UsedImplicitly]
     public class ListSummaryDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public IEnumerable<ListLanguagesDto> Languages { get; set; }
         public string Name { get; set; }
         public IEnumerable<ListTagDto> Tags { get; set; }

diff --git a/src/FilterLists.Services/FilterList/Models/MaintainerAdditionalListsDto.cs b/src/FilterLists.Services/FilterList/Models/MaintainerAdditionalListsDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.FilterList.Models
     [UsedImplicitly]
     public class MaintainerAdditionalListsDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string Name { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/FilterListSeedDto.cs b/src/FilterLists.Services/Seed/Models/FilterListSeedDto.cs
@@ -6,7 +6,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class FilterListSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string ChatUrl { get; set; }
         public string Description { get; set; }
         public string DescriptionSourceUrl { get; set; }
@@ -16,12 +16,12 @@ public class FilterListSeedDto
         public string ForumUrl { get; set; }
         public string HomeUrl { get; set; }
         public string IssuesUrl { get; set; }
-        public uint? LicenseId { get; set; }
+        public int? LicenseId { get; set; }
         public string Name { get; set; }
         public string PolicyUrl { get; set; }
         public DateTime? PublishedDate { get; set; }
         public string SubmissionUrl { get; set; }
-        public uint? SyntaxId { get; set; }
+        public int? SyntaxId { get; set; }
         public string ViewUrl { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/FilterListLanguageSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/FilterListLanguageSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class FilterListLanguageSeedDto
     {
-        public uint FilterListId { get; set; }
-        public uint LanguageId { get; set; }
+        public int FilterListId { get; set; }
+        public int LanguageId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/FilterListMaintainerSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/FilterListMaintainerSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class FilterListMaintainerSeedDto
     {
-        public uint FilterListId { get; set; }
-        public uint MaintainerId { get; set; }
+        public int FilterListId { get; set; }
+        public int MaintainerId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/FilterListTagSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/FilterListTagSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class FilterListTagSeedDto
     {
-        public uint FilterListId { get; set; }
-        public uint TagId { get; set; }
+        public int FilterListId { get; set; }
+        public int TagId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/ForkSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/ForkSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class ForkSeedDto
     {
-        public uint ForkFilterListId { get; set; }
-        public uint UpstreamFilterListId { get; set; }
+        public int ForkFilterListId { get; set; }
+        public int UpstreamFilterListId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/MergeSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/MergeSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class MergeSeedDto
     {
-        public uint MergeFilterListId { get; set; }
-        public uint UpstreamFilterListId { get; set; }
+        public int MergeFilterListId { get; set; }
+        public int UpstreamFilterListId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/Junctions/SoftwareSyntaxSeedDto.cs b/src/FilterLists.Services/Seed/Models/Junctions/SoftwareSyntaxSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models.Junctions
     [UsedImplicitly]
     public class SoftwareSyntaxSeedDto
     {
-        public uint SoftwareId { get; set; }
-        public uint SyntaxId { get; set; }
+        public int SoftwareId { get; set; }
+        public int SyntaxId { get; set; }
     }
 }
diff --git a/src/FilterLists.Services/Seed/Models/LanguageSeedDto.cs b/src/FilterLists.Services/Seed/Models/LanguageSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class LanguageSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string Iso6391 { get; set; }
         public string Iso6392 { get; set; }
         public string Iso6392B { get; set; }

diff --git a/src/FilterLists.Services/Seed/Models/LicenseSeedDto.cs b/src/FilterLists.Services/Seed/Models/LicenseSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class LicenseSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string DescriptionUrl { get; set; }
         public string Name { get; set; }
         public bool PermissiveAdaptation { get; set; }

diff --git a/src/FilterLists.Services/Seed/Models/MaintainerSeedDto.cs b/src/FilterLists.Services/Seed/Models/MaintainerSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class MaintainerSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string EmailAddress { get; set; }
         public string HomeUrl { get; set; }
         public string Name { get; set; }

diff --git a/src/FilterLists.Services/Seed/Models/SoftwareSeedDto.cs b/src/FilterLists.Services/Seed/Models/SoftwareSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class SoftwareSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string DownloadUrl { get; set; }
         public string HomeUrl { get; set; }
         public string Name { get; set; }

diff --git a/src/FilterLists.Services/Seed/Models/SyntaxSeedDto.cs b/src/FilterLists.Services/Seed/Models/SyntaxSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class SyntaxSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string DefinitionUrl { get; set; }
         public string Name { get; set; }
     }

diff --git a/src/FilterLists.Services/Seed/Models/TagSeedDto.cs b/src/FilterLists.Services/Seed/Models/TagSeedDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Seed.Models
     [UsedImplicitly]
     public class TagSeedDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string Description { get; set; }
         public string Name { get; set; }
     }

diff --git a/src/FilterLists.Services/Snapshot/Models/FilterListViewUrlDto.cs b/src/FilterLists.Services/Snapshot/Models/FilterListViewUrlDto.cs
@@ -5,7 +5,7 @@ namespace FilterLists.Services.Snapshot.Models
     [UsedImplicitly]
     public class FilterListViewUrlDto
     {
-        public uint Id { get; set; }
+        public int Id { get; set; }
         public string ViewUrl { get; set; }
     }
 }