re-redo #4592 #4600
Draft
re-redo #4592 #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-redo #4592
sample error from original #4592
the current ef core seeding method can't handle new FilterListViewUrl Ids for the same FilterListId/Primariness combo. for now, we need to revise these FilterListViewUrl changes to use the same FilterListViewUrl Ids for each pre-existing FilterListId/Primariness combo. sorry, this is a pain. I'll try to do it eventually if I have time, but feel free to tackle it @celenityy if you beat me to it.