-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish a transpiled RN version #11
Comments
colmbrady
added a commit
that referenced
this issue
Feb 17, 2018
- change babel build to output preserved directory structure - remove depend on lottie-web as bodymovin is used directly instead - change RN ios and android files to reference dist not src. - remove "src" from distribution as its no longer needed. Issue #11
colmbrady
added a commit
that referenced
this issue
Feb 18, 2018
- change babel build to output preserved directory structure - remove depend on lottie-web as bodymovin is used directly instead - change RN ios and android files to reference dist not src. - remove "src" from distribution as its no longer needed. Issue #11
facebook/react-native#7850 It seems the general wisdom is that only transpiled modules should be published, however there is some issues with React Native packager which may mean that source maps dont get applied. Here is more info: https://gist.github.com/ide/e7b9181984933ebb0755c7367a32e7e8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seeing as ReactXP is targetting browser and native, I think it makes sense to ship transpiled module on native also.
facebook/react-native#7850
https://stackoverflow.com/questions/37277215/transpile-react-native-module-to-es5-before-publishing-to-npm
Need to figure out whether this has implications on an upgrade path. I dont believe it does.
The text was updated successfully, but these errors were encountered: