-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix incorrect type definition for Range
The function represented by Range should return a Color, not a number. Fixes #298.
- Loading branch information
1 parent
cf124a4
commit e8d75a2
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ import Color, { ColorTypes } from "./color"; | |
import ColorSpace from "./space"; | ||
import { Methods } from "./deltaE/index"; | ||
|
||
export type Range = ((percentage: number) => number) & { | ||
export type Range = ((percentage: number) => Color) & { | ||
This comment has been minimized.
Sorry, something went wrong. |
||
rangeArgs: { colors: [Color, Color]; options: Record<string, any> }; | ||
This comment has been minimized.
Sorry, something went wrong.
lloydk
Collaborator
|
||
}; | ||
|
||
|
I think this should be a
ColorObject
or if #291 is merged aPlainColorObject
.