Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrast] Add re-export of src/contrast/index.js to src/index-fn.js #240

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

MysteryBlokHed
Copy link
Member

Adds a missing re-export of the contrast functions to src/index-fn.js.

From #162 (comment):

Is it correct that the named contrast functions e.g. contrastAPCA are not included in colorjs.io/fn?

They should be. If not, it's a bug. But I believe they are exported en masse from contrast/index-fn.js, so if you're searching the source for contrastAPCA it won't find anything.

I've updated the TypeScript tests to make sure the contrast methods are importable through src/index-fn.js, but I'm not sure if there's anything to change for the tests in tests/.

@LeaVerou
Copy link
Member

LeaVerou commented Nov 8, 2022

LGTM, thanks!

@LeaVerou LeaVerou merged commit b4cadc2 into color-js:main Nov 8, 2022
@MysteryBlokHed MysteryBlokHed deleted the contrast/add-fn-export branch November 8, 2022 16:56
@manuelmeister
Copy link
Contributor

@LeaVerou When can we expect a new release, with all the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants