Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter type of Color.defineFunction #251

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Fix parameter type of Color.defineFunction #251

merged 2 commits into from
Dec 2, 2022

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Dec 2, 2022

The function may return something else. For example: deltaE returns a number.

@latin-1
Fix parameter type of Color.defineFunction
82548fa 
The function may return something else. For example: `deltaE` returns a number.
@latin-1
Fix
c35d768
MysteryBlokHed
MysteryBlokHed approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functions passed to Color.defineFunction don't have anything preventing them from returning any value.

@LeaVerou
Copy link
Member

LeaVerou commented Dec 2, 2022

Thank you both!

@LeaVerou LeaVerou merged commit c905aff into color-js:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysteryBlokHed MysteryBlokHed MysteryBlokHed approved these changes

@jgerigmeyer jgerigmeyer Awaiting requested review from jgerigmeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@latin-1 @LeaVerou @MysteryBlokHed