[toGamut] Ensure toGamut always returns a color object #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling toGamut with a color that is already in gamut
for the specified color space would return the original
color parameter which may or may not be a color object.
For example calling toGamut("red", "oklch") would return "red"
instead of a color object.
This change ensures that a color object will always be returned.
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
toGamut()with a color that is already in gamut for the specified color space would return the original color parameter which may or may not be a color object.For example calling
toGamut("red", "oklch")would return "red" instead of a color object.This change ensures that a color object will always be returned.