Add core maintainers to website footer. #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
facelessuser
approved these changes
Feb 10, 2024
svgeesus
approved these changes
Feb 11, 2024
LeaVerou
requested changes
Feb 11, 2024
There was a problem hiding this comment.
Folks, while I was the one that suggested we invite @lloydk as a co-maintainer (and everyone enthusiastically agreed), this is a discussion that needed to happen before we add them to public facing things like these, this cannot be how they find out we’ve invited them 😅
Also, when I opened #414 I was envisioning adding the core maintainers, i.e. those who have been around a while and are also org members. @lloydk definitely has the volume and length of contribution for that, but I think it's still good practice to see how we all work together as a team first, even for a little bit.
LeaVerou
approved these changes
Feb 11, 2024
|
Merged, thanks @jgerigmeyer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414.
I ordered maintainers by date of first commit to the repo.
cc @lloydk