Allow hsluv to be gamut mapped using the CSS algorithm #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hsluv color space wasn't being gamut mapped by the CSS algorithm because it was considered to be an unbounded space and the CSS algorithm exits early if a space is unbounded. Changing the 's' and 'l' coordinates to use range instead of refRange makes hsluv a bounded space and allows it to be gamut mapped properly. Note that testing if a hsluv color was in gamut worked properly because the gamutSpace of hsluv is srgb which is a bounded space.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
approved these changes
Feb 13, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hsluvcolor space wasn't being gamut mapped by the CSS algorithm because it was considered to be an unbounded space and the CSS algorithm exits early if a space is unbounded.Changing the
sandlcoordinates to userangeinstead ofrefRangemakeshsluva bounded space and allows it to be gamut mapped properly.Note that testing if a
hsluvcolor was in gamut worked properly because thegamutSpaceofhsluvissrgbwhich is a bounded space.Convert app with
sandlusingrefRange:sandlchanged to userange: