check libxml on windows

colorer · Sep 17, 2024 · 44e9b54 · 44e9b54
1 parent 41eaf15
commit 44e9b54
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/colorer_ci.yml b/.github/workflows/colorer_ci.yml
@@ -83,6 +83,7 @@ jobs:
         arch: [ x64, x86 ]
         icu: [ON, OFF]
         zip: [ON, OFF]
+        libxml: [ON, OFF]
         include:
           - arch: x64
             triplet: x64-windows-static-rel
@@ -92,7 +93,7 @@ jobs:
           - arch: x86
             zip: OFF
 
-    name: windows-${{ matrix.arch }}-icu_${{ matrix.icu }}-zip_${{ matrix.zip }}
+    name: windows-${{ matrix.arch }}-icu_${{ matrix.icu }}-zip_${{ matrix.zip }}-libxml_${{ matrix.libxml }}
 
     steps:
       - name: Checkout source
@@ -145,6 +146,7 @@ jobs:
           -DVCPKG_FEATURE_FLAGS=manifests,versions
           -DCOLORER_USE_ICU_STRINGS=${{ matrix.icu }}
           -DCOLORER_USE_ZIPINPUTSOURCE=${{ matrix.zip }}
+          -DCOLORER_USE_LIBXML=${{ matrix.libxml }}
 
       - name: Build
         shell: bash

diff --git a/src/colorer/xml/libxml2/LibXmlReader.cpp b/src/colorer/xml/libxml2/LibXmlReader.cpp
@@ -150,7 +150,7 @@ xmlParserInputPtr LibXmlReader::xmlMyExternalEntityLoader(const char* URL, const
 
 void LibXmlReader::xml_error_func(void* /*ctx*/, const char* msg, ...)
 {
-  static char buf[PATH_MAX];
+  static char buf[4096];
   static int slen = 0;
   va_list args;
 

diff --git a/vcpkg.json b/vcpkg.json
@@ -14,6 +14,10 @@
       "features": [
         "data-archive"
       ]
+    },
+    {
+      "name": "libxml2",
+      "default-features": false
     }
   ],
   "builtin-baseline": "53bef8994c541b6561884a8395ea35715ece75db"