Moved testng dependency to compile-only to force the user to provide …

…it (#2168) Pull request: #2168
com-lihaoyi · Dec 6, 2022 · 080038a · 080038a
1 parent 3e3f5d3
commit 080038a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/build.sc b/build.sc
@@ -719,10 +719,9 @@ object contrib extends MillModule {
     // pure Java implementation
     override def artifactSuffix: T[String] = ""
     override def scalaLibraryIvyDeps: Target[Agg[Dep]] = T { Agg.empty[Dep] }
-    override def ivyDeps = Agg(
-      Deps.sbtTestInterface,
-      Deps.testng
-    )
+    override def ivyDeps = Agg(Deps.sbtTestInterface)
+    override def compileIvyDeps = Agg(Deps.testng)
+    override def runIvyDeps = Agg(Deps.testng)
     override def testArgs = T {
       Seq(
         "-DMILL_SCALA_LIB=" + scalalib.runClasspath().map(_.path).mkString(","),

diff --git a/scalalib/src/TestModule.scala b/scalalib/src/TestModule.scala
@@ -192,7 +192,7 @@ object TestModule {
 
   /**
    * TestModule using TestNG Framework to run tests.
-   * You may want to provide the testng dependency explicitly to use another version.
+   * You need to provide the testng dependency yourself.
    */
   trait TestNg extends TestModule {
     override def testFramework: T[String] = "mill.testng.TestNGFramework"