Skip to content

Commit

Permalink
Don't print unwanted debug messages - Multilogger prefers first logger (
Browse files Browse the repository at this point in the history
#2001)

A better solution would be to add the `debugEnabled` flag to the constructor parameters of `MultiLogger`, but that would affect binary compatibilty.

Pull request: #2001
  • Loading branch information
lefou authored Aug 24, 2022
1 parent 521e91d commit d2a859a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion main/util/src/mill/util/Loggers.scala
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ class MultiStream(stream1: OutputStream, stream2: OutputStream)
}
})

// TODO: make this a non-case class
case class MultiLogger(colored: Boolean, logger1: Logger, logger2: Logger, inStream: InputStream)
extends Logger {

Expand Down Expand Up @@ -265,7 +266,8 @@ case class MultiLogger(colored: Boolean, logger1: Logger, logger2: Logger, inStr
logger2.close()
}

override def debugEnabled: Boolean = logger1.debugEnabled || logger2.debugEnabled
// TODO: this should be a ctr parameter, to let the user decide, but this affects binary compatibility
override def debugEnabled: Boolean = logger1.debugEnabled
}

/**
Expand Down

0 comments on commit d2a859a

Please sign in to comment.