Do not compile hidden files #402
Comments
|
A workaround currently is to ignore the those temporary files by adding something like the following to your module: override def allSourceFiles = super.allSourceFiles().filter(!_.path.segments.last.startsWith(".")) |
|
I would be willing to work on this for a permanent solution. Do we have a consensus that ignoring hidden files is a reasonable default? |
|
I believe we do
…On Tue, 28 Aug 2018 at 10:59 AM, Joseph K. Strauss ***@***.***> wrote:
I would be willing to work on this for a permanent solution. Do we have a
consensus that ignoring hidden files is a reasonable default?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#402 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATpwjFz4MpkJPQozqsjWUVsyETNyupwAks5uVLH5gaJpZM4VvZA8>
.
|
|
While you're at it, I think we should drop hidden files from assembly too: #383 (comment) |
vic
added a commit
to vic/mill
that referenced
this issue
Sep 1, 2018
Mill was trying to read all files found under the source directory to create a digest for each of them. This was causing an error for broken symlinks. At first I believed temporary files should be ignored to avoid this problem, and asked at the gitter channel how to go about this, but overriding the `sources` task as [suggested](https://gitter.im/lihaoyi/mill?at=5ad6cd801130fe3d36eb7655) by @lihaoyi didn't actually help. on a simple scala project, editing a file with Emacs, creates a link file, like: ``` vic@oeiuwq ~/h/foo> ls -la foo/src/ total 8 drwxr-xr-x 4 vic staff 128 Sep 1 12:23 . lrwxr-xr-x 1 vic staff 22 Sep 1 12:23 .#hello.scala -> [email protected] drwxr-xr-x 3 vic staff 96 Sep 1 12:22 .. -rw-r--r-- 1 vic staff 12 Sep 1 12:22 hello.scala ``` So this patch only makes sures that the files (or the symlink here) is actually readable before trying to digest it. Fixes com-lihaoyi#402
rockjam
added a commit
that referenced
this issue
Sep 3, 2018
rockjam
added a commit
that referenced
this issue
Sep 3, 2018
lihaoyi
pushed a commit
that referenced
this issue
Sep 5, 2018
Mill was trying to read all files found under the source directory to create a digest for each of them. This was causing an error for broken symlinks. At first I believed temporary files should be ignored to avoid this problem, and asked at the gitter channel how to go about this, but overriding the `sources` task as [suggested](https://gitter.im/lihaoyi/mill?at=5ad6cd801130fe3d36eb7655) by @lihaoyi didn't actually help. on a simple scala project, editing a file with Emacs, creates a link file, like: ``` vic@oeiuwq ~/h/foo> ls -la foo/src/ total 8 drwxr-xr-x 4 vic staff 128 Sep 1 12:23 . lrwxr-xr-x 1 vic staff 22 Sep 1 12:23 .#hello.scala -> [email protected] drwxr-xr-x 3 vic staff 96 Sep 1 12:22 .. -rw-r--r-- 1 vic staff 12 Sep 1 12:22 hello.scala ``` So this patch only makes sures that the files (or the symlink here) is actually readable before trying to digest it. Fixes #402
lihaoyi
pushed a commit
that referenced
this issue
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a file starts with a
., it shouldn't be compiled, even if it ends with.scala. This matches the behavior of sbt and is pretty important for correctness since emacs likes to create backup files.#Foo.scala.The text was updated successfully, but these errors were encountered: