Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer inherit ammonite cli parser config #1960

Merged
merged 8 commits into from
Feb 18, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Jul 19, 2022

Also make the config class an simple non-case class to support easier evolution.

@lefou lefou added the compat-breaker This PR is good to merge, but breaks compatibility and needs to wait till we prepare a major release label Jul 20, 2022
@lefou
Copy link
Member Author

lefou commented Jul 20, 2022

This one is currently breaking binary compatibility, as I removed a val from the config case class.

@lefou lefou marked this pull request as ready for review February 16, 2023 15:23
@lefou lefou merged commit d0e4308 into com-lihaoyi:main Feb 18, 2023
@lefou lefou deleted the fix-cli-parser branch February 18, 2023 15:28
@lefou lefou added this to the 0.11.0-M5 milestone Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat-breaker This PR is good to merge, but breaks compatibility and needs to wait till we prepare a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple duplicate help flags
1 participant