scalapblib- support specifying individual source files #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Nov 16, 2022
| @@ -108,7 +106,7 @@ class ScalaPBWorker extends AutoCloseable { | |||
|
|
|||
| trait ScalaPBWorkerApi { | |||
| def compileScalaPB( | |||
| root: File, | |||
There was a problem hiding this comment.
I suggest to keep an overloaded (maybe deprecated) method with the old signature (it can simply forward to the new implementation though), to keep binary compatibility and avoid breaking someones workflow. You never know, who is already using or integrating this module.
oridag
force-pushed
the
scalapblib-individual-sources
branch
from
4ef1dba
to
2dcd5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ScalalPB plugins only allows specifying whole directories as source. This change allows specifying individual files as inputs.
In addition, ScalaPBC is now invoked once for all input paths instead of separate invocation for each input path. This is important because it allows setting package scoped options to take affect across all input paths.