Update bloop-config to 1.5.4 and update used API #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloop Config introduced some binary incompatible API change between 1.5.3 and 1.5.4. I update the upickle JSON reader/writer setup and adapted to the new API. I just forward a `None` to the source generators though, although, technically, we probably should add a more sophisticated setup, as Mill is able to generate source code and is also very aware of the fact it's generating it and if needs updates. I simply left a TODO note in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bloop Config introduced some binary incompatible API change between 1.5.3 and 1.5.4.
I update the upickle JSON reader/writer setup and adapted to the new API.
I just forward a
Noneto the source generators, although, technically,we probably should add a more sophisticated setup, as Mill is able to generate source code
and is also very aware of the fact it's generating it and if it needs updates.
I simply left a TODO note in the code.