Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked .mill-jvm-opts reader to support files without final newline #2162

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Reworked .mill-jvm-opts reader to support files without final newline #2162

merged 1 commit into from
Dec 2, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Nov 30, 2022 •
edited
Loading

Reworked .mill-jvm-opts reader in shell script prepended to the mill assembly jar.

I tried to keep POSIX shell compatibility, hence it's a bit lenghty.

Fix #2140

@lefou
Reworked .mill-jvm-opts reader to support files without final newline
a0ffc4a 
I tried to keep POSIX shell compatibility, hence it's a bit lenghty.

Fix com-lihaoyi#2140
@lefou lefou mentioned this pull request Dec 1, 2022
Closed
@lefou lefou marked this pull request as ready for review December 1, 2022 10:30
@lefou lefou merged commit 3a63870 into com-lihaoyi:main Dec 2, 2022
@lefou lefou deleted the predef-mill-jvm-opts branch December 2, 2022 08:18
@lefou lefou added this to the 0.10.10 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.10
Development

Successfully merging this pull request may close these issues.

When .mill-jvm-opts doesn't end with a newline, the last parameter is ignored
1 participant
@lefou