Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved testng dependency to compile-only to force the user to provide it #2168

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Moved testng dependency to compile-only to force the user to provide it #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d117ac
Moved testng dependency to compile-only to force the user to provide it
lefou Dec 6, 2022
198acce
Update documentation
lefou Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions build.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,10 +719,9 @@ object contrib extends MillModule {
// pure Java implementation
override def artifactSuffix: T[String] = ""
override def scalaLibraryIvyDeps: Target[Agg[Dep]] = T { Agg.empty[Dep] }
override def ivyDeps = Agg(
Deps.sbtTestInterface,
Deps.testng
)
override def ivyDeps = Agg(Deps.sbtTestInterface)
override def compileIvyDeps = Agg(Deps.testng)
override def runIvyDeps = Agg(Deps.testng)
override def testArgs = T {
Seq(
"-DMILL_SCALA_LIB=" + scalalib.runClasspath().map(_.path).mkString(","),
Expand Down
2 changes: 1 addition & 1 deletion scalalib/src/TestModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ object TestModule {

/**
* TestModule using TestNG Framework to run tests.
* You may want to provide the testng dependency explicitly to use another version.
* You need to provide the testng dependency yourself.
*/
trait TestNg extends TestModule {
override def testFramework: T[String] = "mill.testng.TestNGFramework"
Expand Down