Don't leak runtime cli imports into generated build scripts #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cli option `--import` is supposed to affect only the runtime classpath, there is no need to persist it's value in the generated scripts. Instead, we hold it in an `DynamicVariabele` at script avaluation time.
lihaoyi
reviewed
Jan 18, 2024
| /** | ||
| * Hold additional runtime dependencies given via the `--import` cli option. | ||
| */ | ||
| private[runner] object CliImports extends DynamicVariable[Seq[String]](Seq.empty) |
There was a problem hiding this comment.
Huh I never knew extends DynamicVariable was a thing, but I guess it works
There was a problem hiding this comment.
Yeah, I first had it as a val in the companion object of MillBuildBootstrap, but acyclic wasn't happy with that. So I moved it and tried to avoid all that nesting, without using a val in a new package object and ended up with this compact thing.
lihaoyi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cli option
--importis supposed to affect only the runtimeclasspath, there is no need to persist it's value in the generated scripts.
Instead, we hold it in an
DynamicVariableat script evaluation time.Pull request: #2978