Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp attribute in junit xml report #3172

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix timestamp attribute in junit xml report #3172

merged 1 commit into from
May 22, 2024

Conversation

romain-gilles-ultra
Copy link
Contributor

There is a bug in the way the testsuite element is generated.

Actual

    <testsuite name="MyTest" tests="4" failures="0" errors="0" skipped="0"
               time="0.724">
        timestamp=2024-05-21T18:57:25
        ...
    </testsuite>

Expected

    <testsuite name="MyTest" tests="4" failures="0" errors="0" skipped="0"
               time="0.724" timestamp="2024-05-21T18:57:25">
        ...
    </testsuite>

The timestamp attribute in not an attribute...

@lefou lefou changed the title Fix timestamp attribute in the testsuite element Fix timestamp attribute in junit xml report May 21, 2024
lefou
lefou approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou
Copy link
Member

lefou commented May 21, 2024

It would be nice to have some unit test that covers the generated xml document.

@lefou lefou merged commit 85583c6 into com-lihaoyi:main May 22, 2024
38 checks passed
@lefou lefou added this to the 0.11.8 milestone May 22, 2024
@romain-gilles-ultra
Copy link
Contributor Author

Hi @lefou
It's fun you were talking about unit test. I was working on it So yes I will add unit test in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.8
Development

Successfully merging this pull request may close these issues.
2 participants
@romain-gilles-ultra @lefou