Fix resolution of children of override lazy val modules
#3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing resolution of modules in the form
override lazy val foo: FooModule = new FooModule{...}, which are necessary when you want to override one module with another. You couldn't resolve them viaresolveor run them from the command line, but you could depend on them from other modules and have then get picked up by planning logicThese turn up in Mill's own build, and I notice I couldn't resolve e.g.
main.codesig.test.cases[callgraph-basic-1-static-method].compilebefore this PR. After this PR, I can.Filtering out
abstractmethods inReflectseems unnecessary, since compilation checks that every method is implemented already.Added a unit test to cover this edge case.
Pull request: #3270