-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mill examples in init #3583
base: main
Are you sure you want to change the base?
Conversation
@lihaoyi I have added some integration tests which tries to download examples from GitHub repo, |
CI should be able to access the internet, not sure why it's failing |
I have found the issue, I was relying on millVersion target to build download URLs. But nor millVersion, neither millLastTag targets returns valid versions when runned on CI. @lihaoyi |
@pawelsadlo I think for the purposes of this ticket, let's skip end-to-end tests that download from Github. Those are inherently non-hermetic and we don't have the infrastructure to stand up test github instances to make them hermetic. Smaller unit tests for the various pieces of logic, and manually exercising the end to end workflow, should be enough for now |
implements #3548
Modifying init to fetch examples from releases page instead of using g8 template