Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mill examples in init #3583

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

pawelsadlo
Copy link
Contributor

@pawelsadlo pawelsadlo commented Sep 20, 2024

implements #3548
Modifying init to fetch examples from releases page instead of using g8 template

@pawelsadlo2
Copy link

@lihaoyi I have added some integration tests which tries to download examples from GitHub repo,
They are working locally but failing on Ci, i assume that CI can't access internet right?

@lihaoyi
Copy link
Member

lihaoyi commented Sep 21, 2024

CI should be able to access the internet, not sure why it's failing

@pawelsadlo
Copy link
Contributor Author

pawelsadlo commented Sep 21, 2024

I have found the issue, I was relying on millVersion target to build download URLs.

But nor millVersion, neither millLastTag targets returns valid versions when runned on CI.

@lihaoyi
Is there any reliable function that return last released mill version already implemented in codebase?

@lihaoyi
Copy link
Member

lihaoyi commented Sep 22, 2024

@pawelsadlo I think for the purposes of this ticket, let's skip end-to-end tests that download from Github. Those are inherently non-hermetic and we don't have the infrastructure to stand up test github instances to make them hermetic. Smaller unit tests for the various pieces of logic, and manually exercising the end to end workflow, should be enough for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants