Share profile loggers between nested evaluations #3885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broaden the scope of
profileLogger
/chromeProfileLogger
from withindef evaluate
to instead last as long as theEvaluator
itself, and share it with any sub-Evaluator
s created e.g. to redirect output duringshow
Evaluator
is nowAutoCloseable
, and needs to be closed after being used inMillBuildBootstrap
and inUnitTester
For now I decided not to share the profilers between different evaluation levels of the meta-build, since they already don't overlap: one goes to
out/
, the parent toout/mill-build/
, etc. We could do that if we think it would be useful to give people a consolidated profile, but it might be a bit more work (e.g. we would need to properly prefix entries in the profile to distinguish the different meta levels).Added a unit test to ensure the
show compile
mill-profile and mill-chrome-profile contain the expected keys for bothshow
and forcompile
and some of its upstream tasksFixes #3879