Fixes:#3868 Added Android Bundle Support #3935

himanshumahajan138 · 2024-11-10T18:41:07Z

Pull Request

Added Android Bundle Support (with alot of updation in Android App Build Process)
Fixes: #3868

Description

The new AndroidAppBundle module adds support for Android app bundles, extending AndroidAppModule. An example of the bundle process is now available in JavaLib. AndroidAppModule and AndroidSdkModule have been updated to support Android resources and the aapt2 tool. Additionally, resource support has been added to the JavaLib and KotlinLib examples.

Related Issues

Link to related issue Follow up Android Support Bounties (3000USD) #3868.

Checklist

New Module AndroidAppBundle (for adding android bundle support extends AndroidAppModule)
New Example for Android Bundle Process (Currently under JavaLib)
Updated AndroidAppModule(added resource support)
Updated AndroidSdkModule(related to Android aapt2 Tool)
Updated JavaLib and KotlinLib Android Examples (added resources support)

Further Addition

Requires @lihaoyi Review for code satisfaction and then further move to Documentation Part(for Build.mill files(updations))

c0d33ngr · 2024-11-10T19:18:30Z

@lihaoyi Java Files are getting linting error is there some command to fix it like the way you gave last time for scala formatting

./mill mill.javalib.palantirformat.PalantirFormatModule/ I think this should do. I got it from your CI test errors

himanshumahajan138 · 2024-11-10T19:21:29Z

@lihaoyi Java Files are getting linting error is there some command to fix it like the way you gave last time for scala formatting

./mill mill.javalib.palantirformat.PalantirFormatModule/ I think this should do. I got it from your CI test errors

Buddy your command worked...
Great Thanks alot dear...

c0d33ngr · 2024-11-10T19:54:52Z

@lihaoyi Java Files are getting linting error is there some command to fix it like the way you gave last time for scala formatting

./mill mill.javalib.palantirformat.PalantirFormatModule/ I think this should do. I got it from your CI test errors

Buddy your command worked... Great Thanks alot dear...
No it didn't. Tried it on mine just now

himanshumahajan138 · 2024-11-10T20:02:44Z

@c0d33ngr buddy i don't know why extra ordinary things happen to me in this world 😂

can you tell me why my test docs failed ?
its showing something like glob error 🤷‍♂️

lihaoyi · 2024-11-10T20:07:39Z

@0xnm not sure if you're available to help review this, if not I'll give it a shot (don't have recent android experience myself)

himanshumahajan138 · 2024-11-10T20:12:57Z

Great, btw I have followed official android latest docs (but they don't have good docs for someone to understand seriously)

Resources that i have followed:

0xnm · 2024-11-10T20:46:09Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+  def aapt2Url: T[String] = Task {
+    "https://dl.google.com/android/maven2/com/android/tools/build/aapt2/8.7.2-12006047/aapt2-8.7.2-12006047-linux.jar"
+  }


This is limiting the whole build functionality to Linux, which is wrong. You already have it available in the Android SDK location, so you don't need to download anything.

aapt2 is available in the build-tools/x.x.x folder

You already call it correctly as androidSdkModule().aapt2Path() in other modules, why it is needed to be downloaded here?

#3935 (comment)

Even if you need to use custom aapt2, you shouldn't limit this PR functionality to Linux only by using tools which are not available on other platforms (e.g. by downloading Linux-variant of aapt2 irrespective of the platform, or by using chmod, which don't exist on Windows system).

Sir Give me 30 mins all the issues sorted let me give the updated code and in that everything will be sorted

0xnm · 2024-11-10T20:47:05Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    // Download and extract AAPT2 tool
+    os.write(aapt2Jar, requests.get(aapt2Url()).bytes)
+    os.unzip(aapt2Jar, Task.dest)
+    os.call(("chmod", "+x", aapt2)) // Make AAPT2 executable


no need to do this, you already have aapt2 coming with build tools.

#3935 (comment)

0xnm · 2024-11-10T20:53:00Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    os.call((
+      "java",
+      "-jar",
+      bundleToolJar,
+      "build-bundle",
+      s"--modules=${zipPath}",
+      s"--output=${bundleFile}"
+    ))


for the Java-related calls you can use methods available in mill.util.Jvm (not sure if they bring any significant benefit, though).

I think for this kind of executable assembly using java -jar is fine; the Jvm.* stuff is mostly for making it convenient to execute loose classpaths where constructing the -cp is annoying

0xnm · 2024-11-10T20:55:00Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+   *
+   * @return PathRef to the generated universal APK.
+   */
+  def androidApk: T[PathRef] = Task {


why APK generation should be in the in the Bundle-related module? What is the use-case to generate APK from AAB instead of building it directly?

Why we created bundle ?

To generate "apks" right, I know you will say that its for uploading straight to Play Store or apple store but its our duty to show and check the validation of bundle from our side so that it will not cause error during uploading to stores
And we are providing the universal apk not the device specific apk so think this should be done coz if user created bundle then they should be able to create apk from it...

Rest what you say will be my priority...

I mean you can upload bundle to Play Store directly as aab file. And you can generate APK as well without going through the bundle flow. So what is the exact use-case of generating APK from AAB?

TBH I don't know what the use-case will be 😅

What you say?

Remove Apk Generation using Bundle (no use-case)

My Doubt:

Should we sign the bundle or not?

0xnm · 2024-11-10T21:01:44Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

+    os.call(Seq(
+      "zip",
+      "-j",
+      unsignedApk.toString,
+      s"${androidDex().path / "classes.dex"}"
+    ))


😂 i think it will work but i didnt tried no worries I will update...

lihaoyi · 2024-11-10T22:41:39Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

-        unsignedApk.toString // Output APK
-      ) ++ Seq(androidDex().path.toString) // Include DEX files
-    )
+    os.copy.over((T.dest / os.up / "androidResources.dest" / "res.apk"), unsignedApk)


os.copy should be enough here, since the body of a Task gets wiped out every time before it runs (unless it has persistent = true

lihaoyi · 2024-11-10T22:42:22Z

scalalib/src/mill/javalib/android/AndroidSdkModule.scala

@@ -66,6 +65,13 @@ trait AndroidSdkModule extends Module {
    PathRef(buildToolsPath().path / "aapt")
  }

+  /**
+   * Provides the path to AAPT2, used for resource handling and APK packaging.


Is there any aapt2 documentation we can link to here?

Yes i will add

lihaoyi · 2024-11-10T22:43:20Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    val baseDir = Task.dest / "base"
+
+    // Create directory structure for Android bundle
+    Seq("manifest", "dex").foreach(d => os.makeDir.all(baseDir / d))


Let's skip thie makedir.All and instead use createFolders = true below where necessary. That will be less fragile as we won't need to worry about them falling out of sync

Actually i was doing this before but i don't know why it was clearing old content before adding new
What you think is happening here 🤔

lihaoyi · 2024-11-10T22:44:07Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+
+    // Copy dex and resource files into the bundle directory
+    os.copy(dexFile, Task.dest / dexFile.last)
+    os.unzip(Task.dest / os.up / "androidResources.dest" / "res.apk", Task.dest)


We should never use Task.dest / os.up, as a task should only write to its own dest folder. Not sure what you are trying to do here, but if you want to write to androidResources.dest then the def androidResources task should do the writing

Actually i want the reas.apk which was generated during the android resources process and in need to add dex file into it and as we know before running androiddex we will always run the android resources so think there will be no issue with the usage of os.up

But still if you say i will call the android resources task rather than using hard-coded path to res.apk

In that case you should copy the res.apk in this task's Test.dest folder and modify your own copy

lihaoyi · 2024-11-10T22:44:20Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    // Copy dex and resource files into the bundle directory
+    os.copy(dexFile, Task.dest / dexFile.last)
+    os.unzip(Task.dest / os.up / "androidResources.dest" / "res.apk", Task.dest)
+    os.copy(Task.dest / "AndroidManifest.xml", baseDir / "manifest" / "AndroidManifest.xml")


We can now write baseDir / "manifest/AndroidManifest.xml"

lihaoyi · 2024-11-10T22:45:34Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    os.walk(Task.dest).filter(_.ext == "dex").zipWithIndex.foreach { case (file, idx) =>
+      os.copy(file, baseDir / "dex" / (if (idx == 0) "classes.dex" else s"classes${idx + 1}.dex"))
+    }


This renaming of .dex files to classes$n.dex is a bit weird. Should we be preserving the original file names like we do for pb?

No sir its also mentioned in the official docs that how to manage multiple dex files

See here: https://developer.android.com/build/building-cmdline#package_pre-compiled_code_and_resources

Got it, in that case please add a comment linking to the relevant documentation

lihaoyi · 2024-11-10T22:45:51Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+   *
+   * @return PathRef to the created bundle zip.
+   */
+  def androidBundleZip: T[PathRef] = Task {


Is there any documentation for what should go in an android bundle zip that we can link to here?

Yes I will add

lihaoyi · 2024-11-10T22:46:43Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    val ResourceZip = compiledZips.find(_.toString.contains("resources"))
+    val libzips = compiledZips.filterNot(_.toString.contains("resources"))


We can do val (resourceZip, libZips) = compiledZips.partition(...)

What are you trying to do with .contains("resources") though? Seems like there should be a better way to do it

Actually during compiling when we have multiple resources like from libs and main user defined resources so at that time we are renaming them res prefix used for libs resources and resources prefix used for user resources zip

So to partition them (as they are in the same folder) i have used this

lihaoyi · 2024-11-10T22:47:42Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+   * URL to download bundle tool, used for creating Android app bundles (AAB files).
+   */
+  def bundleToolUrl: T[String] = Task {
+    "https://github.com/google/bundletool/releases/download/1.17.2/bundletool-all-1.17.2.jar"


Should this be on AndroidSdkModule? That way it would be in the same place as the other downloaded tools and maybe be easier to find

lihaoyi · 2024-11-10T22:48:22Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

+      // If the res folder exists, add it to the resource folders
+      val resFolder = extractDir / "res"
+      if (os.exists(resFolder)) {
+        resFolders :+= PathRef(resFolder)


Let's use resFolders ++= Seq(PathRef(resFolder))

lihaoyi · 2024-11-10T22:49:30Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    val resourceDirs = resources().map(_.path).filter(os.exists)
+
+    // Download and extract AAPT2 tool
+    os.write(aapt2Jar, requests.get(aapt2Url()).bytes)


I think we don't need the .bytes here, and don't need a temporary local file to download to and unpack if we do os.unzip.stream(requests.get.stream(aapt2Url()), Task.dest

But yeah if it's already in AndroidSdkModule we don't need this here at all

#3935 (comment)

lihaoyi · 2024-11-10T22:50:52Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    val compiledZips = resourceDirs.map { resDir =>
+      val outputZip = compiledResDir / s"${resDir.last}-${count}.zip"
+      count += 1
+      os.call((


This can probably be one lined

lihaoyi · 2024-11-10T22:51:24Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    }
+
+    // Copy additional resources (res, lib, assets) if present
+    Seq("res", "lib", "assets").foreach { folder =>


Better to use for loops than .foreach for this kind of thing, here and elsewhere in the PR

himanshumahajan138 · 2024-11-11T04:24:42Z

@0xnm and @lihaoyi i know you are concerned about the usage of aapt2 from the downloaded version

Actually its clearly mentioned in the official docs that we can't use aapt2 which came bundled with build tools

See this: https://developer.android.com/build/building-cmdline#bundletool-build

And if you are concerned about the os specific link dont worry about that also we can use os property to use the download link as per os

himanshumahajan138 · 2024-11-11T05:02:14Z

I Request @0xnm and @lihaoyi to please check my replies for every review and again review them as most of these are already solved and some requires updation so rather than giving small small updates lets first figure out every possible update again and then finalize it

lihaoyi · 2024-11-11T05:53:13Z

@himanshumahajan138 if the docs say to download it separately that's fine, but there should be a comment linking to the relevant documentation

himanshumahajan138 · 2024-11-11T06:33:42Z

@himanshumahajan138 if the docs say to download it separately that's fine, but there should be a comment linking to the relevant documentation

Let me do experiment 😂, i will try the aapt2 which came bundled and see if there is some issue if not then we can use the bundled one 🙃

lihaoyi · 2024-11-11T13:28:28Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

-   * project's `AndroidManifest.xml` and any additional resource directories. It creates
-   * the necessary R.java files and other compiled resources for Android. These generated
-   * resources are crucial for the app to function correctly on Android devices.
+   * @return A task that yields an updated set of artifact types including "aar".


This scaladoc comment is useless; it should be replaced by something non-obvious, and not just duplicate what is obvious from the 1 line of code below

himanshumahajan138 · 2024-11-11T13:59:30Z

This toString.contains("resources") is still unacceptably sloppy. Since we construct the paths ourselves above in outputZip, we should be able to be more precise in exactly how we determine something is a resource vs a library. At the very least we should be able to look at resDir.segments.toSeq and check individual path segments rather than stringifying the whole thing

@lihaoyi I created Multiple resource folders situation for you and now explain me what you want to achieve

here app-resources.zip is the zip which contains user resources
and other zips are for libraries resources (dependencies)

lihaoyi · 2024-11-11T15:43:03Z

If thats what you need to do the you need to find abetter way to do it

himanshumahajan138 · 2024-11-12T13:09:14Z

@lihaoyi @0xnm Let's Review this again for more refining if required...

Overall code is working, apps + bundles are working as expected
Need Further Reviews and then Final Documentation Part for build Files...

lihaoyi · 2024-11-12T14:03:49Z

example/kotlinlib/android/1-hello-world/app/src/main/java/com/helloworld/app/MainActivity.kt

+        textView.layoutParams = LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT)
+
+        // Set the text color using a resource
+        textView.setTextColor(getColor(R.color.text_green)) // Using hex color code directly


What does // Using hex color code directly mean?

😂😂😂 actually these documentations are not updated i will update them with updation of build docs

lihaoyi · 2024-11-12T14:04:22Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    val baseDir = Task.dest / "base"
+    val appDir = Task.dest / "app"
+
+    // Copy dex and resource files into the bundle directory


All these comments are redundant and should be removed

lihaoyi · 2024-11-12T14:05:18Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    for ((file, idx) <- os.walk(Task.dest).filter(_.ext == "dex").zipWithIndex) {
+      os.copy(
+        file,
+        baseDir / "dex" / (if (idx == 0) "classes.dex" else s"classes${idx + 1}.dex"),


Where is the documentation link for the classes{n}.dex file names?

sorry forgot will add this time

@lihaoyi actually docs for all the bundle format is already added above in its scaladoc

do i need to explicitly add the documentation link for classes(n).dex format above this line as inline comment

Such split is a part of multidex https://developer.android.com/build/multidex#mdex-on-l, you can reference this page if you want.

I'm not sure though why you don't preserve original file name: in your case original classes2.dex may become classes3.dex or classes.dex, for example, if the order of enumeration produced by walk is not the same as alphabetical ordering? Or are class files you are traversing have different naming?

I would suggest keeping original names, because classes.dex has a special treatment: it is always loaded first and some classes are packaged there specifically to allow application start.

lihaoyi · 2024-11-12T14:06:25Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

+   * Combines module resources with those unpacked from AARs.
+   */
+  def resources: T[Seq[PathRef]] = Task {
+    // Call the function to unpack AARs and get the jar and resource paths


This comments are redundant and can be removed

himanshumahajan138 · 2024-11-12T14:09:35Z

Please Confirm once if code is acceptable then should i move to documentation Part ???

himanshumahajan138 · 2024-11-12T16:32:49Z

@lihaoyi ThirdParty Arrow Test Failed 🥲 why these type of extra ordinary things happen with me...

lihaoyi · 2024-11-12T17:08:48Z

That test is flaky, you can ignore it

himanshumahajan138 · 2024-11-12T17:09:59Z

ok then let's Finalize this PR

0xnm · 2024-11-12T22:11:40Z

scalalib/src/mill/javalib/android/AndroidAppBundle.scala

+    for ((file, idx) <- os.walk(Task.dest).filter(_.ext == "dex").zipWithIndex) {
+      os.copy(
+        file,
+        baseDir / "dex" / (if (idx == 0) "classes.dex" else s"classes${idx + 1}.dex"),


Such split is a part of multidex https://developer.android.com/build/multidex#mdex-on-l, you can reference this page if you want.

I'm not sure though why you don't preserve original file name: in your case original classes2.dex may become classes3.dex or classes.dex, for example, if the order of enumeration produced by walk is not the same as alphabetical ordering? Or are class files you are traversing have different naming?

I would suggest keeping original names, because classes.dex has a special treatment: it is always loaded first and some classes are packaged there specifically to allow application start.

0xnm · 2024-11-12T22:17:19Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

   */
  def androidSdkModule: ModuleRef[AndroidSdkModule]

  /**
-   * An XML file containing configuration and metadata about your android application
+   * Loads `AndroidManifest.xml` file.


Does it load anything? It seems it just provides a path.

😂 it don't loads anything it provides path i used loads as to make it short and simple

0xnm · 2024-11-12T22:18:49Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

-   * for the application.
+   * Adds "aar" to the handled artifact types.
+   */
+  def artifactTypes: T[Set[coursier.Type]] = Task { super.artifactTypes() + coursier.Type("aar") }


there is aar support added here, but examples lack any 3rd party dependency, is it intentional?

As mentioned below this will be used in future in jetpack compose or third-party addition examples

0xnm · 2024-11-12T22:20:08Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

+  /**
+   * Extracts JAR files and resources from AAR dependencies.
+   *
+   * @return Paths to extracted JAR files and resource folders.
+   */


there is no any dependency usage in the examples, so I believe this method is not really tested?

Actually its tested in my pr #3769 i have tested it my self and we will require this in future for kotlin jetpack compose or any other aar library support

And if we want to test it again don't worry we will do that while merging #3769

0xnm · 2024-11-12T22:22:10Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

-        jarFile.toString, // Output JAR file
-        "--no-desugaring" // Disable desugaring
+        jarFile.toString,
+        "--no-desugaring"


desugaring is a configurable parameter in the build setup in Gradle, so maybe it makes sense to make it configurable here as well

Yes we can i will update to desugaring

0xnm · 2024-11-12T22:24:23Z

scalalib/src/mill/javalib/android/AndroidAppModule.scala

+      androidKeystore().path,
+      "--ks-key-alias",
+      "androidkey",
+      "--ks-pass",
+      "pass:android",
+      "--key-pass",
+      "pass:android",
+      "--out",


this is only for the debug key, obviously. If someone want to build a signed release package, it should be an option to provide a singing configuration: release key and credentials for it.

No worries we will add a function which will take args from user and then sign...

himanshumahajan138 · 2024-11-13T04:16:22Z

#3935 (comment)

Actually i do agree with preserving original names as they will be already present in different names like classes.dex or classes2.dex and there will be no duplicate name files as they all are made during same dex process and it will provide different names

So no worries i will update the dex file handling...

Anything else ?

himanshumahajan138 · 2024-11-13T12:14:37Z

@lihaoyi @0xnm Updated Code, Resolved Reviews

Let's Review Again for More Refining (almost near to set a record for 100+ comments 😂)

Please Review...

lihaoyi · 2024-11-13T13:50:44Z

@himanshumahajan138 how are you testing this? I'm trying to load the aab file into my android emulator but it doesn't seem to be generating an icon on the home screen for me to open the app

himanshumahajan138 · 2024-11-13T13:52:44Z

@himanshumahajan138 how are you testing this? I'm trying to load the aab file into my android emulator but it doesn't seem to be generating an icon on the home screen for me to open the app

This is not the appropriate way to test and deploy apk from aab bundle

let me provide you the way to do this just go to the commit #070c71f there i have added how to create apk file from aab

Here is some of the code part if you want to try using CLI you can also do that

 /**
   * Generates a universal APK from the signed Android App Bundle (AAB).
   *
   * @return PathRef to the generated universal APK.
   */
  def androidApk: T[PathRef] = Task {
    val apkSet = Task.dest / "app.apks"

    // Use bundle tool to generate APK set from the signed AAB
    os.call((
      "java",
      "-jar",
      Task.dest / os.up / "androidBundle.dest" / "bundleTool.jar",
      "build-apks",
      "--ks",
      androidKeystore().path,
      s"--bundle=${signBundle().path}",
      s"--output=$apkSet",
      "--mode=universal", // Universal APK for broader compatibility
      "--ks-key-alias",
      "androidkey",
      "--ks-pass",
      "pass:android"
    ))

    // Extract the universal APK from the APK set
    os.unzip(apkSet, Task.dest)

    PathRef(Task.dest / "universal.apk")
  }

after this install the universal.apk in to your emulator

i Removed this coz @0xnm Said there is no use case of creating android apk from bundle 😅

himanshumahajan138 · 2024-11-13T14:06:26Z

@lihaoyi What you think should we add Android Apk Generation from AAB Bundle ?

lihaoyi · 2024-11-13T14:08:17Z

So what is the appropriate way to deploy the AAB bundle so i csn verify it is working as expected?

lihaoyi · 2024-11-13T14:09:06Z

Do i have to deploy it all the way to google play store? Ir is there some way to test it locally?

himanshumahajan138 · 2024-11-13T14:11:50Z

if you want to test locally then use this comment #3935 (comment)

else you can also try playstore or appstore but they are not suggested as you just want to test not to produce it for market

lihaoyi · 2024-11-13T14:13:18Z

got it, let me try that out

himanshumahajan138 · 2024-11-13T14:17:35Z

@lihaoyi let me give you a shortcut

if you have some zip tool app like 7 zip or others, try to open the apk from example 1 and then bundle from example 2

now check the files present in the apk unzip
match them with the files present in the base folder inside the aab unzip
if they are same then means aab will work same as apk from 1st example

This is my way to test them Something Extraordinary 😂

himanshumahajan138 added 2 commits November 10, 2024 18:22

Fixes:com-lihaoyi#3868 First Test Phase

88c8dce

Lint Fixture

069e401

Java Lint Fixture

070c71f

0xnm reviewed Nov 10, 2024

View reviewed changes

lihaoyi reviewed Nov 10, 2024

View reviewed changes

Merge branch 'main' into issue-3868-final

eef4520

himanshumahajan138 and others added 2 commits November 11, 2024 18:08

Merge branch 'main' into issue-3868-final

5a04a97

Reviews Resolved

b6ac901

lihaoyi reviewed Nov 11, 2024

View reviewed changes

himanshumahajan138 and others added 2 commits November 12, 2024 18:35

Merge branch 'main' into issue-3868-final

be20e8e

Reviews Resolved: Fixture

e9d66a2

lihaoyi reviewed Nov 12, 2024

View reviewed changes

Documentation Updated: Final Fixture

21fc638

0xnm reviewed Nov 12, 2024

View reviewed changes

lihaoyi mentioned this pull request Nov 13, 2024

Add Android Linting Example #3931

Open

Reviews Fixture

3d41d7e

himanshumahajan138 and others added 2 commits November 13, 2024 19:32

Added SDK TOOLS DOCUMENTATION LINK

4d35348

Merge branch 'main' into issue-3868-final

ffd6dd5

		val ResourceZip = compiledZips.find(_.toString.contains("resources"))
		val libzips = compiledZips.filterNot(_.toString.contains("resources"))

Fixes:#3868 Added Android Bundle Support #3935

Are you sure you want to change the base?

Fixes:#3868 Added Android Bundle Support #3935

Conversation

himanshumahajan138 commented Nov 10, 2024 • edited by lihaoyi Loading

Pull Request

Description

Related Issues

Checklist

Further Addition

c0d33ngr commented Nov 10, 2024

himanshumahajan138 commented Nov 10, 2024 • edited Loading

c0d33ngr commented Nov 10, 2024

himanshumahajan138 commented Nov 10, 2024 • edited Loading

lihaoyi commented Nov 10, 2024

himanshumahajan138 commented Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lihaoyi Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himanshumahajan138 Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lihaoyi Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himanshumahajan138 commented Nov 11, 2024 • edited Loading

himanshumahajan138 commented Nov 11, 2024 • edited Loading

lihaoyi commented Nov 11, 2024

himanshumahajan138 commented Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

himanshumahajan138 commented Nov 11, 2024 • edited Loading

lihaoyi commented Nov 11, 2024

himanshumahajan138 commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himanshumahajan138 commented Nov 12, 2024

himanshumahajan138 commented Nov 12, 2024

lihaoyi commented Nov 12, 2024

himanshumahajan138 commented Nov 12, 2024 • edited Loading

himanshumahajan138 commented Nov 10, 2024 •

edited by lihaoyi

Loading

himanshumahajan138 commented Nov 10, 2024 •

edited

Loading

himanshumahajan138 commented Nov 10, 2024 •

edited

Loading

himanshumahajan138 commented Nov 10, 2024 •

edited

Loading

lihaoyi Nov 10, 2024 •

edited

Loading

himanshumahajan138 Nov 11, 2024 •

edited

Loading

lihaoyi Nov 10, 2024 •

edited

Loading

himanshumahajan138 commented Nov 11, 2024 •

edited

Loading

himanshumahajan138 commented Nov 11, 2024 •

edited

Loading

himanshumahajan138 commented Nov 11, 2024 •

edited

Loading

himanshumahajan138 commented Nov 11, 2024 •

edited

Loading

himanshumahajan138 commented Nov 12, 2024 •

edited

Loading