Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scoverage: inherit repositories from outer project #645

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

krcz
Copy link
Contributor

@krcz krcz commented Jul 2, 2019

ScoverageModule submodule inherits ivyDeps from the outer project, not inheriting repositories, which creates problems with resolving when package is in custom repository (#620).

@lefou
Copy link
Member

lefou commented Jul 2, 2019

Thank you. I'll merge when tests pass. But please notice, this is not the only issue with the scoverage module right now. See discussion of #640 if you are interested.

@krcz
Copy link
Contributor Author

krcz commented Jul 2, 2019

@lefou I don't think I have good enough knowledge on mill internals to provide a good solution on that - I just started using it two weeks ago.

I believe generally the problem is that you need to compile all the sources with additional compiler options you don't want in the final build - and it seems that mill doesn't support tasks parametrized by some context, which is why scoverage attempts to clone the original build, but there are many edge cases where it doesn't work. In case of your issue I might try adding def generatedSources = outer.generatedSources as well, but I'm not sure if that's going to work.

@lefou lefou merged commit 139cd51 into com-lihaoyi:master Jul 2, 2019
@lefou lefou added this to the after-0.4.2 milestone Jul 2, 2019
@nvander1
Copy link
Contributor

nvander1 commented Jul 2, 2019

@krcz Thanks for this fix! And you're right about the generatedSources I believe. @lefou I forsee a lot of other small things needing to be assigned from the outer module in scoverage. Or at least, the will probably be the first type of fix to try.

@krcz
Copy link
Contributor Author

krcz commented Jul 2, 2019

@lefou Thank you for quick response and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants