Scala-Native 0.5.0 support #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
reviewed
Apr 14, 2024
build.sc
Outdated
| @@ -28,7 +24,7 @@ trait SourcecodeModule extends PublishModule with MimaCheck { | |||
| // Temporary until the next version of Mima gets released with | |||
| // https://github.com/lightbend/mima/issues/693 included in the release. | |||
| def mimaPreviousArtifacts = | |||
| if(isScala3(crossScalaVersion)) Agg.empty[Dep] else super.mimaPreviousArtifacts() | |||
| if(crossScalaVersion.startsWith("3.")) Agg.empty[Dep] else super.mimaPreviousArtifacts() | |||
There was a problem hiding this comment.
isScala3 still exists but is inside ZincWorkerUtil now I believe
|
|
||
| def scalaNativeVersion = "0.5.0" | ||
| object test extends ScalaNativeTests{ | ||
| // stub to make use of test plumbing but not running a test suite |
There was a problem hiding this comment.
Why can't we run tests on Scala Native?
There was a problem hiding this comment.
@lolgab sourcecode doesnt use a test framework, it just runs through the asserts starting from def main. But the build level plumbing for nested test modules w.r.t. cross version and cross platform modules is very handy, so I'm abusing it a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a Mill version upgrade to 0.11.x, which involved cleaning up a lot of now-unnecessary boilerplate in the
build.sc.Same version changes as elsewhere: drop 2.11.x/3.1.x/3.2.x support, add Scala-Native 0.5.0