Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConditioningSetArea - areas must be dividable by 64 #2

Closed
kutny opened this issue Jan 31, 2023 · 2 comments
Closed

ConditioningSetArea - areas must be dividable by 64 #2

kutny opened this issue Jan 31, 2023 · 2 comments

Comments

@kutny
Copy link

kutny commented Jan 31, 2023

Hi,

first thanks a lot for your work! The visual form of the pipeline helped me a lot to better understand some basic concepts of SD!

My challenge:
I would like to "inpaint" all the 5 windows in the following room using image2image or depth2image. I hoped that such approach would help SD to render the windows in a correct size and position - currently, the model often forgets them or make them much bigger

.

The problem is that I cannot create a small enough ConditioningSetArea (smaller than 64x64 or just at any size which is not dividable by 64).

Do you think that there is some solution to that? Standard inpainting uses a mask image where the mask can have any shape. Can such mask also be used in your approach somehow?

Thanks
@kutny kutny changed the title ConditioningSetArea - areas not dividable by 64 ConditioningSetArea - areas must be dividable by 64 Jan 31, 2023
@comfyanonymous
Copy link
Owner

Yes it will be possible to use masks in that way once I implement them.

flyingshutter pushed a commit to flyingshutter/ComfyUI that referenced this issue Apr 2, 2023
@FizzleDorf
Merge pull request comfyanonymous#2 from flyingshutter/fizzle296
5dcbade 
Fizzle296
comfyanonymous added a commit that referenced this issue Apr 3, 2023
@comfyanonymous
Squashed commit of the following:
ff16ea7 
commit 9c39a41
Author: FizzleDorf <[email protected]>
Date:   Sun Apr 2 16:40:11 2023 -0400

    changed denoise incr/decr amount to 0.1

commit aeab59e
Author: FizzleDorf <[email protected]>
Date:   Sun Apr 2 16:10:15 2023 -0400

    start_at_step and end_at_step skipped for adding valueControls

commit a2d0919
Author: FizzleDorf <[email protected]>
Date:   Sun Apr 2 15:48:35 2023 -0400

    all fixed, names changed to reflect expanded functionality

commit d95c994
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 15:26:40 2023 -0400

    fixed incr/decr for steps

commit aa6f6e6
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 15:03:37 2023 -0400

    controls now apply to number values except steps in inc/decr modes

commit 27d0a8d
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 14:06:02 2023 -0400

    seedControls now appears for all number parameters when converted into a primitive node.

commit f6796a5
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 13:36:47 2023 -0400

    third time's the charm

commit a40c380
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 13:17:38 2023 -0400

    won't let me revert because it missed a file

commit d090a3f
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 13:16:25 2023 -0400

    archiving changes

commit 33d301b
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 02:38:08 2023 -0400

    overlooked min/max for unused code

commit 9f5b8cf
Author: FizzleDorf <[email protected]>
Date:   Sat Apr 1 02:35:57 2023 -0400

    halt batching for min/max seed values

commit ec3e40e
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 20:47:51 2023 -0400

    flyingshutter's code added, in working order

commit 5dcbade
Merge: 27bae07 12ba214
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 19:28:58 2023 -0400

    Merge pull request #2 from flyingshutter/fizzle296

    Fizzle296

commit 12ba214
Author: flyingshutter <[email protected]>
Date:   Sat Apr 1 01:27:11 2023 +0200

    remove randomizing combo

commit adb0ea4
Merge: d0935a8 27bae07
Author: flyingshutter <[email protected]>
Date:   Sat Apr 1 01:16:33 2023 +0200

    Merge branch 'seedControls' into fizzle296

commit d0935a8
Merge: 04e43b7 704421e
Author: flyingshutter <[email protected]>
Date:   Sat Apr 1 01:12:05 2023 +0200

    Merge branch 'master' into fizzle296

commit 27bae07
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 19:03:09 2023 -0400

    resolved merge

commit 05756a2
Merge: e21e609 704421e
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 18:59:21 2023 -0400

    merge

commit 704421e
Merge: d794424 0d972b8
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 18:51:01 2023 -0400

    Merge remote-tracking branch 'upstream/master'
    merge to current ver

commit e21e609
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 18:50:47 2023 -0400

    comments

commit 04e43b7
Merge: 18a6c1d 4661163
Author: flyingshutter <[email protected]>
Date:   Sat Apr 1 00:16:28 2023 +0200

    Merge branch 'pr/296' into fizzle296

commit 4661163
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 23:58:09 2023 +0200

    set seedControl to fexed seed for non seed numbers

commit 540cf3f
Merge: 21b0104 0b08c65
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 23:29:28 2023 +0200

    Merge branch 'seedControls' of https://github.com/FizzleDorf/ComfyUI into pr/296

commit 21b0104
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 23:27:06 2023 +0200

    cleanup return value of seedWidget

commit 0b08c65
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 14:57:03 2023 -0400

    primitive node title fix

commit 662f297
Merge: 6566a4a 8100f63
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 20:28:26 2023 +0200

    Merge branch 'seedControls' of https://github.com/FizzleDorf/ComfyUI into pr/296

commit 6566a4a
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 20:23:46 2023 +0200

    fix params in call to addSeedControlWidget
    was: ...(this, this.widget, "randomize")
    isnow: (this, widget, "randomize")

commit 8100f63
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 14:08:33 2023 -0400

    seed node changed to before I tried links

commit e3657c7
Merge: e47e2c2 91f27f0
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 13:40:38 2023 -0400

    Merge remote-tracking branch 'upstream/master' into seedControls
    merging

commit e47e2c2
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 13:40:19 2023 -0400

    tried linking, no luck

commit 3fe7648
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 19:20:47 2023 +0200

    make createWidget subtype aware
    -> if (widget.name === "seed") is not necessary anymore

commit 6cc52b4
Author: flyingshutter <[email protected]>
Date:   Fri Mar 31 19:18:58 2023 +0200

    do not serialize seedControl

commit 03502bc
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 03:51:52 2023 -0400

    seed controls now appear in new seed nodes

commit 505821d
Author: FizzleDorf <[email protected]>
Date:   Fri Mar 31 01:14:10 2023 -0400

    trying some things but no luck

commit c8e0185
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 23:02:09 2023 -0400

    back to where I'm at

commit 521a0ee
Merge: a295d74 fbe3df1
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 22:42:11 2023 -0400

    almost there

commit a295d74
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 22:41:01 2023 -0400

    back to normal

commit fbe3df1
Merge: ee1e423 ea5dc10
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 21:59:55 2023 -0400

    Merge branch 'seedControls' of https://github.com/FizzleDorf/ComfyUI into seedControls
    fixing name

commit ee1e423
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 21:59:47 2023 -0400

    random commit

commit d794424
Author: FizzleDorf <[email protected]>
Date:   Thu Mar 30 21:55:12 2023 -0400

    random commit
@comfyanonymous
Copy link
Owner

Both Conditioning masks and non multiples of 64 for ConditioningSetArea are implemented now.

BackendForge referenced this issue in BackendForge/ComfyUI Aug 21, 2023
@pythongosssss
# This is a combination of 3 commits.
8109382 
# This is the 1st commit message:

remove log

# This is the commit message #2:

add submodule

# This is the commit message comfyanonymous#3:

add basic password COMFY_KEY
comfyanonymous pushed a commit that referenced this issue Sep 19, 2023
@enzymezoo-code
Ci quality workflows (#1423)
26cd840 
* Add inference tests

* Clean up

* Rename test graph file

* Add readme for tests

* Separate server fixture

* test file name change

* Assert images are generated

* Clean up comments

* Add __init__.py so tests can run with command line `pytest`

* Fix command line args for pytest

* Loop all samplers/schedulers in test_inference.py

* Ci quality workflows compare (#1)

* Add image comparison tests

* Comparison tests do not pass with empty metadata

* Ensure tests are run in correct order

* Save image files  with test name

* Update tests readme

* Reduce step counts in tests to ~halve runtime

* Ci quality workflows build (#2)

* Add build test github workflow
HorusElohim pushed a commit to HorusElohim/PyfyUI that referenced this issue Sep 22, 2023
@enzymezoo-code @HorusElohim
Ci quality workflows (comfyanonymous#1423)
0d71772 
* Add inference tests

* Clean up

* Rename test graph file

* Add readme for tests

* Separate server fixture

* test file name change

* Assert images are generated

* Clean up comments

* Add __init__.py so tests can run with command line `pytest`

* Fix command line args for pytest

* Loop all samplers/schedulers in test_inference.py

* Ci quality workflows compare (comfyanonymous#1)

* Add image comparison tests

* Comparison tests do not pass with empty metadata

* Ensure tests are run in correct order

* Save image files  with test name

* Update tests readme

* Reduce step counts in tests to ~halve runtime

* Ci quality workflows build (comfyanonymous#2)

* Add build test github workflow
ltdrdata pushed a commit to ltdrdata/ComfyUI that referenced this issue Oct 9, 2023
@guill
Rework Caching (comfyanonymous#2)
7d4530f 
This commit solves a number of bugs and adds some caching related
functionality. Specifically:

1. Caching is now input-based. In cases of completely identical nodes,
   the output will be reused (for example, if you have multiple
   LoadCheckpoint nodes loading the same checkpoint). If a node doesn't
   want this behavior (e.g. a `RandomInteger` node, it should set
   `NOT_IDEMPOTENT = True`.
2. This means that nodes within a component will now be cached and will
   only change if the input actually changes. Note that types that can't
   be hashed by default will always count as changed (though the
   component itself will only expand if one of its inputs changes).
3. A new LRU caching strategy is now available by starting with
   `--cache-lru 100`. With this strategy, in addition to the latest
   workflow being cached, up to N (100 in the example) node outputs will
   be retained. This allows users to work on multiple workflows or
   experiment with different inputs without losing the benefits of
   caching (at the cost of more RAM and VRAM). I intentionally left some
   additional debug print statements in for this strategy for the
   moment.
4. A new endpoint `/debugcache` has been temporarily added to assist
   with tracking down issues people encounter. It allows you to browse
   the contents of the cache.
5. Outputs from ephemeral nodes will now be communicated to the
   front-end with both the ephemeral node id, the 'parent' node id, and
   the 'display' node id. The front-end has been updated to deal with
   this.
Omer-ler referenced this issue in uglabs/ComfyUI Nov 14, 2023
@pydn
Merge pull request #2 from pydn/2023-08-07_add_inference_mode
de8b64d 
2023 08 07 add inference mode
@WLJ2012 WLJ2012 mentioned this issue Nov 26, 2023
Open
1iyiwei pushed a commit to 1iyiwei/ComfyUI that referenced this issue Feb 26, 2024
Merge pull request comfyanonymous#2 from AnimaGen/liyiwei
bce9140 
Add workflows
mid-dev-media pushed a commit to mid-dev-media/ComfyUI that referenced this issue Mar 16, 2024
@MaraScott
Merge pull request comfyanonymous#2 from ltdrdata/main
10480c7 
pull latest
@Yangseok Yangseok mentioned this issue Apr 10, 2024
Open
@anonymousoneday anonymousoneday mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kutny @comfyanonymous