Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend to v1.2.47 #4798

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Update frontend to v1.2.47 #4798

merged 2 commits into from
Sep 5, 2024

Conversation

huchenlei
Copy link
Collaborator

@huchenlei huchenlei commented Sep 5, 2024

Changelog

Features

UI Improvements

Major refactor: Used TreeExplorer on nodeLibrarySidebarTab (#699)
Added custom background image feature (#698)
Implemented double-click group title to edit (#714)
Added edit group name on group creation (With Ctrl + g) (#715)
Triggered searchbox on group body double click (#731)

Core Functionality

Updated litegraph to ES6 LGraphCanvas (#679)
Added confirm dialog on window close
Replaced locking with pinning in core (#734)
Added keyboard shortcut for pin/unpin node (#736)

New Features

Added beforeRegisterVueAppNodeDefs hook (#709)
Initiated model store implementation (#674)
Added locale setting (#708)

Bug Fixes

Fixed top level bookmark migration (#706)
Updated litegraph to fix node.pos serialization (#711)
Implemented auto transforms for bugged node positions (#712)
Fixed load of string node id workflow (#744)
Restored context menu for new searchbox (#724)

Misc

Performance Optimizations

Stored shallowRef of litegraph canvas (#722)
Added eager init for nodeSearchService (#713)

Developer Tools

Added component test (Vitest) (#681)
Updated GitHub action run conditions (#682)
Added tree explorer tree node test
Added test on text widget popover dismiss (#732)

Documentation

Added ToastMessageOptions docs to README (#721)
Updated README (#733)

Build and Release

Disabled minify on release dist (#737)
Implemented release script (#746)

Version Releases

1.2.41, 1.2.42, 1.2.43, 1.2.44, 1.2.45, 1.2.46, 1.2.47

Minor Changes

Removed GitHub button in error dialog
Various small refactors and code cleanup

@comfyanonymous comfyanonymous merged commit fa34efe into master Sep 5, 2024
3 checks passed
@comfyanonymous comfyanonymous deleted the release-1.2.47 branch September 5, 2024 22:56
thomastraum added a commit to thomastraum/ComfyUI that referenced this pull request Oct 4, 2024
commit 6cc962e
Merge: 34104b4 d854ed0
Author: tommi @tm-10 <[email protected]>
Date:   Fri Oct 4 13:05:15 2024 +0100

    Merge branch 'master' of https://github.com/thomastraum/ComfyUI

commit 34104b4
Author: tommi @tm-10 <[email protected]>
Date:   Fri Oct 4 13:04:01 2024 +0100

    added .venv

commit d854ed0
Author: comfyanonymous <[email protected]>
Date:   Thu Oct 3 09:44:54 2024 -0400

    Allow using SD3 type te output on flux model.

commit abcd006
Author: comfyanonymous <[email protected]>
Date:   Thu Oct 3 09:26:11 2024 -0400

    Allow more permutations of clip/t5 in dual clip loader.

commit d985d1d
Author: comfyanonymous <[email protected]>
Date:   Wed Oct 2 04:25:17 2024 -0400

    CLIP Loader node now supports clip_l and clip_g only for SD3.

commit d1cdf51
Author: comfyanonymous <[email protected]>
Date:   Tue Oct 1 07:08:41 2024 -0400

    Refactor some of the TE detection code.

commit b4626ab
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 30 06:03:27 2024 -0400

    Add simpletuner lycoris format for SD unet.

commit a9e459c
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 29 11:13:53 2024 -0400

    Use torch.nn.functional.linear in RGB preview code.

    Add an optional bias to the latent RGB preview code.

commit 3bb4dec
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 28 14:42:14 2024 -0400

    Fix issue with loras, lowvram and --fast fp8.

commit 8733191
Author: City <[email protected]>
Date:   Sat Sep 28 04:07:51 2024 +0200

    Flux torch.compile fix (comfyanonymous#5082)

commit 83b01f9
Author: comfyanonymous <[email protected]>
Date:   Fri Sep 27 02:12:37 2024 -0400

    Add backend option to TorchCompileModel.

    If you want to use the cudagraphs backend you need to: --disable-cuda-malloc

    If you get other backends working feel free to make a PR to add them.

commit d72e871
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 26 03:17:52 2024 -0400

    Add a note that the experimental model downloader api will be removed.

commit 037c315
Author: comfyanonymous <[email protected]>
Date:   Wed Sep 25 03:24:13 2024 -0400

    Move some nodes out of _for_testing.

commit bdd4a22
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 24 22:57:22 2024 -0400

    Fix flux TE not loading t5 embeddings.

commit fdf3756
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 24 04:32:55 2024 -0400

    Add batch size to EmptyLatentAudio.

commit 08c8968
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Tue Sep 24 16:50:45 2024 +0900

    Internal download API: Add proper validated directory input (comfyanonymous#4981)

    * add internal /folder_paths route

    returns a json maps of folder paths

    * (minor) format download_models.py

    * initial folder path input on download api

    * actually, require folder_path and clean up some code

    * partial tests update

    * fix & logging

    * also download to a tmp file not the live file

    to avoid compounding errors from network failure

    * update tests again

    * test tweaks

    * workaround the first tests blocker

    * fix file handling in tests

    * rewrite test for create_model_path

    * minor doc fix

    * avoid 'mock_directory'

    use temp dir to avoid accidental fs pollution from tests

commit 479a427
Author: chaObserv <[email protected]>
Date:   Tue Sep 24 14:42:56 2024 +0800

    Add dpmpp_2m_cfg_pp (comfyanonymous#4992)

commit 3a0eeee
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 23 04:38:19 2024 -0400

    Make --listen listen on both ipv4 and ipv6 at the same time by default.

commit 447da7e
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 23 04:36:59 2024 -0400

    Support listening on multiple addresses.

commit 9c41bc8
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 23 02:32:29 2024 -0400

    Remove useless line.

commit 6ad0ddb
Author: Robin Huang <[email protected]>
Date:   Sun Sep 22 18:01:39 2024 +0900

    Run unit tests on Windows/MacOS as well. (comfyanonymous#5018)

    * Run unit tests on Windows as well.

    * Test on mac.

    * Continue running on error.

    * Compared normalized paths to work cross platform.

    * Only test common set of mimetypes across operating systems.

commit a55142f
Author: RandomGitUser321 <[email protected]>
Date:   Sun Sep 22 04:59:10 2024 -0400

    Add ws.close() to the websocket examples (comfyanonymous#5020)

    * add ws.close() to websocket examples

    * add and explain ws.close() in websocket examples

commit 5718ef6
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 22 03:41:48 2024 -0400

    Add total and free ram to /system_stats.

commit 13ecf10
Author: RandomGitUser321 <[email protected]>
Date:   Sun Sep 22 02:30:44 2024 -0400

    Added to the websockets_api_example.py to show how to decode latent previews from the binary stream (comfyanonymous#5016)

    * Update websockets_api_example.py

    * even more simplfied

commit 7a415f4
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 22 01:24:52 2024 -0400

    Add an optional VAE input to the ControlNetApplyAdvanced node.

    Deprecate the other controlnet nodes.

commit 89fa2fc
Author: Chenlei Hu <[email protected]>
Date:   Sun Sep 22 12:28:54 2024 +0900

    Update web content to release v1.2.60 (comfyanonymous#5017)

    * Update web content to release v1.2.60

    * Remove dist.zip

commit 364b69e
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 21 09:12:31 2024 -0400

    Make SD3 empty latent image zeros.

    This shouldn't change anything. The reason it was not zeros is because it
    did matter in early versions of the code.

commit dc96a1a
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 21 04:50:12 2024 -0400

    Load controlnet in fp8 if weights are in fp8.

commit 2d810b0
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 21 01:51:51 2024 -0400

    Add load_controlnet_state_dict function.

commit 9f7e9f0
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 21 01:33:18 2024 -0400

    Add an error message when a controlnet needs a VAE but none is given.

commit a355f38
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 21 01:32:46 2024 -0400

    Make the SD3 controlnet node the default one.

commit 38c6908
Author: huchenlei <[email protected]>
Date:   Fri Sep 13 15:44:32 2024 +0900

    Add docstring

commit 70a708d
Author: comfyanonymous <[email protected]>
Date:   Fri Sep 20 02:31:44 2024 -0400

    Fix model merging issue.

commit e7d4782
Author: yoinked <[email protected]>
Date:   Thu Sep 19 20:23:09 2024 -0700

    add laplace scheduler [2407.03297] (comfyanonymous#4990)

    * add laplace scheduler [2407.03297]

    * should be here instead lol

    * better settings

commit 3326bdf
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Thu Sep 19 22:52:55 2024 +0900

    add internal /folder_paths route (comfyanonymous#4980)

    returns a json maps of folder paths

commit 68bb885
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Thu Sep 19 21:59:55 2024 +0900

    add 'is_default' to model paths config (comfyanonymous#4979)

    * add 'is_default' to model paths config

    including impl and doc in example file

    * update weirdly overspecific test expectations

    * oh there's two

    * sigh

commit ad66f7c
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 19 05:01:00 2024 -0400

    Add model_options to load_controlnet function.

commit de8e8e3
Author: Simon Lui <[email protected]>
Date:   Thu Sep 19 18:11:42 2024 +0900

    Fix xpu Pytorch nightly build from calling optimize which doesn't exist. (comfyanonymous#4978)

commit a1e71cf
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Thu Sep 19 17:40:14 2024 +0900

    very simple strong-cache on model list (comfyanonymous#4969)

    * very simple strong-cache on model list

    * store the cache after validation too

    * only cache object_info for now

    * use a 'with' context

commit 0bfc7cc
Author: comfyanonymous <[email protected]>
Date:   Wed Sep 18 09:39:43 2024 -0400

    Create the temp directory on ComfyUI startup instead.

commit 7183fd1
Author: Tom <[email protected]>
Date:   Tue Sep 17 09:22:05 2024 +0100

    Add route to list model types (comfyanonymous#4846)

    * Add list models route

    * Better readable model types list

commit 254838f
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Tue Sep 17 16:57:17 2024 +0900

    add simple error check to model loading (comfyanonymous#4950)

commit 0b7dfa9
Author: pharmapsychotic <[email protected]>
Date:   Tue Sep 17 02:51:10 2024 -0500

    Improve tiling calculations to reduce number of tiles that need to be processed. (comfyanonymous#4944)

commit d514bb3
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 17 03:49:54 2024 -0400

    Add some option to model_options for the text encoder.

    load_device, offload_device and the initial_device can now be set.

commit 0849c80
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 17 01:57:59 2024 -0400

    get_key_patches now works without unloading the model.

commit 56e8f5e
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 16 00:30:36 2024 -0400

    VAEDecodeAudio now does some normalization on the audio.

commit e813abb
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 15 07:59:18 2024 -0400

    Long CLIP L support for SDXL, SD3 and Flux.

    Use the *CLIPLoader nodes.

commit 5e68a4c
Author: JettHu <[email protected]>
Date:   Sun Sep 15 13:03:09 2024 +0800

    Reduce repeated calls of INPUT_TYPES in cache (comfyanonymous#4922)

commit ca08597
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 14 09:17:13 2024 -0400

    Make the inpaint controlnet node work with non inpaint ones.

commit f48e390
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 14 09:05:16 2024 -0400

    Support AliMama SD3 and Flux inpaint controlnets.

    Use the ControlNetInpaintingAliMamaApply node.

commit 369a6dd
Author: Chenlei Hu <[email protected]>
Date:   Sat Sep 14 12:30:44 2024 +0900

    Remove empty spaces in user_manager.py (comfyanonymous#4917)

commit b3ce8fb
Author: comfyanonymous <[email protected]>
Date:   Fri Sep 13 23:24:47 2024 -0400

    Revert "Reduce repeated calls of get_immediate_node_signature for ancestors in cache (comfyanonymous#4871)"

    This reverts commit f6b7194.

commit cf80d28
Author: comfyanonymous <[email protected]>
Date:   Fri Sep 13 09:52:20 2024 -0400

    Support loading controlnets with different input.

commit 6fb44c4
Author: Acly <[email protected]>
Date:   Fri Sep 13 14:25:11 2024 +0200

    Make adding links/nodes to ExecutionList non-recursive (comfyanonymous#4886)

    Graphs with 300+ chained nodes run into maximum recursion depth error (limit is 1000 in CPython)

commit d2247c1
Author: Chenlei Hu <[email protected]>
Date:   Fri Sep 13 16:45:31 2024 +0900

    Normalize path returned by /userdata to always use / as separator (comfyanonymous#4906)

commit cb12ad7
Author: Chenlei Hu <[email protected]>
Date:   Fri Sep 13 15:40:59 2024 +0900

    Add full_info flag in /userdata endpoint to list out file size and last modified timestamp (comfyanonymous#4905)

    * Add full_info flag in /userdata endpoint to list out file size and last modified timestamp

    * nit

commit f6b7194
Author: JettHu <[email protected]>
Date:   Fri Sep 13 11:02:52 2024 +0800

    Reduce repeated calls of get_immediate_node_signature for ancestors in cache (comfyanonymous#4871)

commit 7c6eb4f
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 12 20:27:07 2024 -0400

    Set some nodes as DEPRECATED.

commit b962db9
Author: Robin Huang <[email protected]>
Date:   Thu Sep 12 21:10:27 2024 +0900

    Add cli arg to override user directory (comfyanonymous#4856)

    * Override user directory.

    * Use overridden user directory.

    * Remove prints.

    * Remove references to global user_files.

    * Remove unused replace_folder function.

    * Remove newline.

    * Remove global during get_user_directory.

    * Add validation.

commit d0b7ab8
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 12 05:23:32 2024 -0400

    Add a simple experimental TorchCompileModel node.

    It probably only works on Linux.

    For maximum speed on Flux with Nvidia 40 series/ada and newer try using
    this node with fp8_e4m3fn and the --fast argument.

commit 405b529
Author: Yoland Yan <[email protected]>
Date:   Thu Sep 12 17:53:08 2024 +0900

    Minor: update tests-unit README.md (comfyanonymous#4896)

commit 9d72018
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 12 03:56:52 2024 -0400

    types -> comfy_types to fix import issue.

commit d247bc5
Author: Robin Huang <[email protected]>
Date:   Thu Sep 12 14:52:06 2024 +0900

    Expand variables in base_path for extra_config_paths.yaml. (comfyanonymous#4893)

    * Expand variables in base_path for extra_config_paths.yaml.

    * Fix comments.

commit 9f4daca
Author: comfyanonymous <[email protected]>
Date:   Wed Sep 11 02:51:36 2024 -0400

    Doesn't really make sense for cfg_pp sampler to call regular one.

commit b5d0f2a
Author: yoinked <[email protected]>
Date:   Tue Sep 10 23:49:44 2024 -0700

    Add CFG++ to DPM++ 2S Ancestral (comfyanonymous#3871)

    * Update sampling.py

    * Update samplers.py

    * my bad

    * "fix" the sampler

    * Update samplers.py

    * i named it wrong

    * minor sampling improvements

    mainly using a dynamic rho value (hey this sounds a lot like smea!!!)

    * revert rho change

    rho? r? its just 1/2

commit e760bf5
Author: bymyself <[email protected]>
Date:   Tue Sep 10 23:00:07 2024 -0700

    Add content-type filter method to folder_paths (comfyanonymous#4054)

    * Add content-type filter method to folder_paths

    * Add unit tests

    * Hardcode webp content-type

    * Annotate content_types as Literal["image", "video", "audio"]

commit 36c83cd
Author: comfyanonymous <[email protected]>
Date:   Wed Sep 11 01:00:31 2024 -0400

    Limit origin check to when host is loopback.

    This should still prevent the exploit without breaking things for people
    who use reverse proxies.

commit 81778a7
Author: Yoland Yan <[email protected]>
Date:   Tue Sep 10 13:44:49 2024 +0900

    [🗻 Mount Fuji Commit] Add unit tests for folder path utilities (comfyanonymous#4869)

    All past 30 min of comtts are done on the top of Mt Fuji
    By Comfy, Robin, and Yoland
    All other comfy org members died on the way

    Introduced unit tests to verify the correctness of various folder path
    utility functions such as `get_directory_by_type`, `annotated_filepath`,
    and `recursive_search` among others. These tests cover scenarios
    including directory retrieval, filepath annotation, recursive file
    searches, and filtering files by extensions, enhancing the robustness
    and reliability of the codebase.

commit bc94662
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 10 00:43:37 2024 -0400

    Cleanup.

commit 9fa8faa
Author: Robin Huang <[email protected]>
Date:   Mon Sep 9 21:33:44 2024 -0700

    Expand user directory for basepath in extra_models_paths.yaml (comfyanonymous#4857)

    * Expand user path.

    * Add test.

    * Add unit test for expanding base path.

    * Simplify unit test.

    * Remove comment.

    * Remove comment.

    * Checkpoints.

    * Refactor.

commit 9a7444e
Author: comfyanonymous <[email protected]>
Date:   Tue Sep 10 00:21:33 2024 -0400

    Add diffusion_models to the extra_model_paths.yaml.example

commit 54fca4a
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 9 16:23:21 2024 -0400

    If host does not contain a port only compare the hostnames.

commit cd49553
Author: Chenlei Hu <[email protected]>
Date:   Mon Sep 9 17:32:55 2024 +0900

    Add back CI action for tests-ui (comfyanonymous#4859)

commit 8354203
Author: david02871 <[email protected]>
Date:   Mon Sep 9 09:31:18 2024 +0100

    Add .venv to gitignore (comfyanonymous#4756)

commit e0b4124
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 9 03:18:17 2024 -0400

    Fix issue where sometimes origin doesn't contain the port.

commit 619263d
Author: Alex "mcmonkey" Goodwin <[email protected]>
Date:   Mon Sep 9 15:55:51 2024 +0900

    allow current timestamp in save image prefix (comfyanonymous#4030)

commit e3b0402
Author: comfyanonymous <[email protected]>
Date:   Mon Sep 9 01:04:03 2024 -0400

    Ignore origin domain when it's empty.

commit 967867d
Author: Darion <[email protected]>
Date:   Sun Sep 8 21:02:32 2024 -0400

    fix: url decode filename from API (comfyanonymous#4801)

commit cbaac71
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 8 19:35:23 2024 -0400

    Fix issue with last commit.

commit 3ab3516
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 8 18:08:28 2024 -0400

    By default only accept requests where origin header matches the host.

    Browsers are dumb and let any website do requests to localhost this should
    prevent this without breaking things. CORS prevents the javascript from
    reading the response but they can still write it.

    At the moment this is only enabled when the --enable-cors-header argument
    is not used.

commit 9c5fca7
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 8 10:10:47 2024 -0400

    Fix lora issue.

commit a5da4d0
Author: guill <[email protected]>
Date:   Sun Sep 8 06:48:47 2024 -0700

    Fix error with ExecutionBlocker and OUTPUT_IS_LIST (comfyanonymous#4836)

    This change resolves an error when a node with OUTPUT_IS_LIST=(True,)
    receives an ExecutionBlocker. I've also added a unit test for this case.

commit 32a60a7
Author: comfyanonymous <[email protected]>
Date:   Sun Sep 8 09:31:41 2024 -0400

    Support onetrainer text encoder Flux lora.

commit bb52934
Author: Jim Winkens <[email protected]>
Date:   Sat Sep 7 05:28:32 2024 -0400

    Fix import issue (comfyanonymous#4815)

commit 8aabd7c
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 7 03:21:02 2024 -0400

    SaveLora node can now save "full diff" lora format.

    This isn't actually a lora format and is saving the full diff of the
    weights in a format that can be used in the lora loader nodes.

commit a09b29c
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 7 02:56:24 2024 -0400

    Add an option to the SaveLora node to store the bias diff.

commit 9bfee68
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 7 02:30:12 2024 -0400

    LoraSave node now supports generating text encoder loras.

    text_encoder_diff should be connected to a CLIPMergeSubtract node.

    model_diff and text_encoder_diff are optional inputs so you can create
    model only loras, text encoder only loras or a lora that contains both.

commit ea77750
Author: comfyanonymous <[email protected]>
Date:   Sat Sep 7 02:13:13 2024 -0400

    Support a generic Comfy format for text encoder loras.

    This is a format with keys like:
    text_encoders.clip_l.transformer.text_model.encoder.layers.9.self_attn.v_proj.lora_up.weight

    Instead of waiting for me to add support for specific lora formats you can
    convert your text encoder loras to this format instead.

    If you want to see an example save a text encoder lora with the SaveLora
    node with the commit right after this one.

commit c27ebeb
Author: comfyanonymous <[email protected]>
Date:   Fri Sep 6 03:21:52 2024 -0400

    Fix onnx export not working on flux.

commit 0c7c98a
Author: guill <[email protected]>
Date:   Thu Sep 5 16:33:02 2024 -0700

    Nodes using UNIQUE_ID as input are NOT_IDEMPOTENT (comfyanonymous#4793)

    As suggested by @ltdrdata, we can automatically consider nodes that take
    the UNIQUE_ID hidden input to be NOT_IDEMPOTENT.

commit dc2eb75
Author: comfyanonymous <[email protected]>
Date:   Thu Sep 5 19:21:52 2024 -0400

    Update stable release workflow to latest pytorch with cuda 12.4.

commit fa34efe
Author: Chenlei Hu <[email protected]>
Date:   Thu Sep 5 15:56:01 2024 -0700

    Update frontend to v1.2.47 (comfyanonymous#4798)

    * Update web content to release v1.2.47

    * Update shortcut list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants