Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct Ping to keep the connection alive #649

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Aug 18, 2021

cc @sethsimmons This might fix #648.

CI is going to attach a binary to the workflow, do you mind giving that one a try and see if the disconnects still appear with that?

Fixes #648.

@sethforprivacy
Copy link
Contributor

Should this new binary be run on just the ASB side or the swap side as well?

I'll deploy it on the ASB side regardless in the morning.

@thomaseizinger
Copy link
Contributor Author

Should this new binary be run on just the ASB side or the swap side as well?

I'll deploy it on the ASB side regardless in the morning.

Just the ASB side is fine.

@thomaseizinger
Copy link
Contributor Author

The artifact will come up on this page at the bottom: https://github.com/comit-network/xmr-btc-swap/actions/runs/1141616002

@sethforprivacy
Copy link
Contributor

The artifact will come up on this page at the bottom: https://github.com/comit-network/xmr-btc-swap/actions/runs/1141616002

Running the x86_64 artifact now.

@sethforprivacy
Copy link
Contributor

So far this patch seems to have at least fixed the log spam of connect/disconnect cycles!

Will have the one swap partner who was having issues retry the resume.

@sethforprivacy
Copy link
Contributor

An unrelated participant was able to successfully complete a swap with the artifact asb running, FWIW.

Logs are much more readable now.

@thomaseizinger
Copy link
Contributor Author

bors r+

@bors bors bot merged commit cd5a137 into master Aug 18, 2021
@bors bors bot deleted the bugfix/648-disconnects branch August 18, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] swap user cannot connect to my ASB reliably via /ip4/ netaddr
2 participants