-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instruct Ping to keep the connection alive #649
Conversation
b7c7152
to
6c44682
Compare
Should this new binary be run on just the ASB side or the swap side as well? I'll deploy it on the ASB side regardless in the morning. |
Just the ASB side is fine. |
The artifact will come up on this page at the bottom: https://github.com/comit-network/xmr-btc-swap/actions/runs/1141616002 |
Running the x86_64 artifact now. |
So far this patch seems to have at least fixed the log spam of connect/disconnect cycles! Will have the one swap partner who was having issues retry the resume. |
An unrelated participant was able to successfully complete a swap with the artifact asb running, FWIW. Logs are much more readable now. |
bors r+ |
cc @sethsimmons This might fix #648.
CI is going to attach a binary to the workflow, do you mind giving that one a try and see if the disconnects still appear with that?
Fixes #648.