-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
camerad: remove thumbnail generation #32199
base: master
Are you sure you want to change the base?
Conversation
adeebshihadeh
commented
Apr 15, 2024
•
edited
Loading
edited
- log qcam i frames
- update pipeline to use the i frames
- check qlog size diff
@deanlee want to make the PR to start publishing thumbnails as the qcam I frames? it should be done generically such that each EncoderInfo can publish its own thumbnail packet with the iframes and a given decimation here's the PR to add an encoding type to thumbnail commaai/msgq#607 |
@adeebshihadeh is it something like this #32202 ? |
Yes, now it just needs to be generic so any encoder can publish one (though we'll only publish the qcam one). |
When we want to add new ones, we'll just make a new log.Event type for them, like "roadEncodeData". |
I see |
This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
old-commit-hash: 574f90c
19df774
to
574f90c
Compare
This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
0556ed1
to
691adb7
Compare