Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camerad: remove thumbnail generation #32199

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Apr 15, 2024

  • log qcam i frames
  • update pipeline to use the i frames
  • check qlog size diff

@adeebshihadeh
Copy link
Contributor Author

@deanlee want to make the PR to start publishing thumbnails as the qcam I frames? it should be done generically such that each EncoderInfo can publish its own thumbnail packet with the iframes and a given decimation

here's the PR to add an encoding type to thumbnail commaai/msgq#607

@adeebshihadeh adeebshihadeh added this to the 0.9.7 milestone Apr 15, 2024
@deanlee
Copy link
Contributor

deanlee commented Apr 15, 2024

@adeebshihadeh is it something like this #32202 ?

@adeebshihadeh
Copy link
Contributor Author

@adeebshihadeh is it something like this #32202 ?

Yes, now it just needs to be generic so any encoder can publish one (though we'll only publish the qcam one).

@adeebshihadeh
Copy link
Contributor Author

But it seems that cereal currently lacks the structure or flags to distinguish between thumbnails from different cameras.

When we want to add new ones, we'll just make a new log.Event type for them, like "roadEncodeData".

@deanlee
Copy link
Contributor

deanlee commented Apr 16, 2024

I see

Copy link
Contributor

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label May 14, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this May 17, 2024
@adeebshihadeh adeebshihadeh reopened this May 17, 2024
@github-actions github-actions bot removed the stale label May 18, 2024
adeebshihadeh and others added 3 commits May 18, 2024 20:30
old-commit-hash: 0556ed1
@adeebshihadeh adeebshihadeh marked this pull request as draft May 22, 2024 00:27
@adeebshihadeh adeebshihadeh modified the milestones: 0.9.7, 0.9.8 May 22, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants