Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable misra-c2012-10.6 #1811

Merged
merged 16 commits into from
Feb 27, 2024
Merged

enable misra-c2012-10.6 #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e36829f
misra-c2012-10.6
0x41head Jan 16, 2024
5b5ad4f
fixed uninitialized data error
0x41head Feb 8, 2024
1ded177
Merge branch 'master' of https://github.com/commaai/panda
0x41head Feb 11, 2024
7d65226
Merge branch 'master' of https://github.com/commaai/panda
0x41head Feb 14, 2024
6e43a5c
Merge branch 'master' of https://github.com/commaai/panda
0x41head Feb 15, 2024
d2a6765
Merge branch 'master' of https://github.com/commaai/panda
0x41head Feb 18, 2024
e0c403a
Merge branch 'commaai:master' into master
0x41head Feb 19, 2024
bf16510
Merge branch 'master' of https://github.com/commaai/panda
0x41head Feb 20, 2024
086b075
Merge branch 'master' of https://github.com/0x41head/panda
0x41head Feb 20, 2024
fd76a55
revert false positive
0x41head Feb 23, 2024
cbbc4c7
enable 10.6
0x41head Feb 27, 2024
b51ee74
update install.sh
0x41head Feb 27, 2024
4f387d3
merge master
0x41head Feb 27, 2024
f06c7bb
cleanup
0x41head Feb 27, 2024
e2ce799
bug fix
0x41head Feb 27, 2024
f8faca6
better fix ?
0x41head Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions board/drivers/usb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ int current_int0_alt_setting = 0;

void *USB_ReadPacket(void *dest, uint16_t len) {
uint32_t *dest_copy = (uint32_t *)dest;
uint32_t count32b = (len + 3U) / 4U;
uint32_t count32b = ((uint32_t)len + 3U) / 4U;

for (uint32_t i = 0; i < count32b; i++) {
*dest_copy = USBx_DFIFO(0);
Expand All @@ -379,9 +379,9 @@ void USB_WritePacket(const void *src, uint16_t len, uint32_t ep) {
hexdump(src, len);
#endif

uint32_t numpacket = (len + (USBPACKET_MAX_SIZE - 1U)) / USBPACKET_MAX_SIZE;
uint32_t numpacket = ((uint32_t)len + (USBPACKET_MAX_SIZE - 1U)) / USBPACKET_MAX_SIZE;
uint32_t count32b = 0;
count32b = (len + 3U) / 4U;
count32b = ((uint32_t)len + 3U) / 4U;

// TODO: revisit this
USBx_INEP(ep)->DIEPTSIZ = ((numpacket << 19) & USB_OTG_DIEPTSIZ_PKTCNT) |
Expand Down
2 changes: 1 addition & 1 deletion tests/misra/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ cd $CPPCHECK_DIR
VERS="2.13.0"
git fetch --all --tags
git checkout $VERS
git cherry-pick -n f6b538e855f0bacea33c4074664628024ef39dc6
git cherry-pick -n f6b538e855f0bacea33c4074664628024ef39dc6 b11b42087ff29569bc3740f5aa07eb6616ea4f63

#make clean
make MATCHCOMPILTER=yes CXXFLAGS="-O2" -j8
1 change: 0 additions & 1 deletion tests/misra/suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,4 @@ misra-c2012-1.2 # this is from the extensions (e.g. __typeof__) used in the MIN
misra-c2012-2.5
misra-c2012-8.7
misra-c2012-8.4
misra-c2012-10.6
misra-c2012-21.15
Loading