Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD-2505 Allow querying for specific secrets #1

Merged

Conversation

shreyayay
Copy link
Contributor

Why is the change needed?

The API used by the java-sdk now also allows querying for specific secrets. This feature can be extended to the SDK as well.

What change has been made?

  • Updated the model to also includeSecretNameFilter
  • Sending the list of secret names (optionally) when fetching rendered secrets.

Other Changes:

  • Dependencies on powermock have been removed as it was causing errors with JDK 17. The last published version was in 2020.
  • Using junit5 instead of junit4 as the dependency on powermock is removed (PowerMock is not officially supported by JUnit 5.)
  • Updated mockito version
  • Refactored test cases to also mock environments response
  • Added a workflow file for build step.

Any callouts?

Previously the test suite was failing as the response for getEnvironmentsWithHttpInfo was not mocked. This has been added under a @BeforeEach setup step now.

Testing

  • Verified in a test project that the secrets can be filtered when using the SDK

Self-Checklist

  • The changes are supported by test cases
  • The changes have been tested in a dev env

@shreyayay shreyayay changed the base branch from init to main August 10, 2023 04:42
Copy link
Contributor

@georgeshanti georgeshanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 💯

@shreyayay shreyayay merged commit a339ac1 into main Aug 10, 2023
1 check passed
@rohanprabhu rohanprabhu deleted the feature/prd-2505-java-sdk-allow-querying-for-specific-secrets branch September 2, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants