hide filemanip instead of Glob in stackage #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2018
|
I am in favor of this change, for the reasons given. Thanks for looking into that. Note to curators: I suspect stackage-curator is not smart enough to automatically handle unhiding filemanip and hiding Glob, if they are already in the package database. To get this change into effect, it may require nuking the existing work and rebuilding everything. (Or an update to stackage-curator to make it know how to more intelligently handle this.) |
|
Thanks for the PR! @DanBurton Thank you for mentioning that, I'll start rebuilding the nightlies now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filemanip and Glob packages both provide the System.FilePath.Glob module, and presumably this is why Glob is marked as a hidden package in build-constraints.yaml. This has required tests to be disabled for several packages, such as multiset, makefile, and hledger-lib even though its cabal file and PackageImports explicitly select Glob.
I suggest filemanip be hidden instead. It's older, unmaintained, and has 60 reverse deps, while Glob is actively maintained and has 112.