Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable cassava-megaparsec, email-validate, yesod, yesod-form #7330

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

simonmichael
Copy link
Contributor

@simonmichael simonmichael commented Feb 28, 2024

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

@ysangkok
Copy link
Contributor

ysangkok commented Mar 6, 2024

This doesn't seem to address all the packages that need yesod or yesod-form. Would it be possible to re-enable those too?
You can see how in CURATORS.md's section on re-enabling.

@simonmichael
Copy link
Contributor Author

I could have done that, but then I'd be responsible for testing and getting all of those to work, potentially delaying getting my packages working again. I figured I would send a followup PR for that.

@simonmichael
Copy link
Contributor Author

But if you'd prefer I do it all in this one, I will.

@ysangkok
Copy link
Contributor

ysangkok commented Mar 6, 2024

I can do it in a separate PR if you'd rather not.

@simonmichael
Copy link
Contributor Author

Ok, thank you @ysangkok.

@DanBurton DanBurton merged commit 37e5e46 into commercialhaskell:master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants