Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headings are nested in <p> elements #430

Closed
zzzzBov opened this issue Sep 9, 2016 · 2 comments
Closed

Headings are nested in <p> elements #430

zzzzBov opened this issue Sep 9, 2016 · 2 comments

Comments

@zzzzBov
Copy link

zzzzBov commented Sep 9, 2016

Raw HTML headings (h2-h6) are wrapped in <p> elements.

example

<h1>lorem</h1>

<h2>lorem</h2>

<h3>lorem</h3>

<h4>lorem</h4>

<h5>lorem</h5>

<h6>lorem</h6>

produces

<h1>lorem</h1>
<p><h2>lorem</h2></p>
<p><h3>lorem</h3></p>
<p><h4>lorem</h4></p>
<p><h5>lorem</h5></p>
<p><h6>lorem</h6></p>
@jgm jgm closed this as completed in f32da1e Sep 12, 2016
jgm added a commit to commonmark/commonmark.js that referenced this issue Sep 12, 2016
@jgm
Recognize h2..h6 as block tags (see commonmark/commonmark-spec#430).
4389319
jgm added a commit to commonmark/cmark that referenced this issue Sep 12, 2016
@jgm
Fixed h2..h6 HTML blocks (commonmark/commonmark-spec#430).
fae6a25 
Added regression test.
jgm added a commit to commonmark/commonmark.js that referenced this issue Sep 12, 2016
@jgm
Added regression test for commonmark/commonmark-spec#430.
12d2580
@zzzzBov
Copy link
Author

zzzzBov commented Sep 12, 2016

@jgm, thanks for the quick fix! What's involved in updating try.commonmark.org?

@jgm
Copy link
Member

jgm commented Sep 12, 2016

It gets updated each time there's a new CommonMark release.

+++ Timothy [Sep 12 16 07:01 ]:

[1]@jgm, thanks for the quick fix! What's involved in updating
try.commonmark.org?

—
You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]mute the
thread.

References

  1. https://github.com/jgm
  2. Headings are nested in <p> elements #430 (comment)
  3. https://github.com/notifications/unsubscribe-auth/AAAL5M41DqcNx3juBoQqdHQphQWMV18Cks5qpVskgaJpZM4J5VvE

zudov added a commit to zudov/haskell-comark that referenced this issue Sep 17, 2016
@zudov
Add h2-h6 to the list of block html tags
56f0300 
See commonmark/commonmark-spec#430
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue May 23, 2017
Updated textproc/cmark 0.26.1 to 0.27.1
2f18532 
---------------------------------------
cmark 0.27.1
 jgm released this on 19 Nov 2016 揃 46 commits to master since this release

 -  Set policy for CMP0063 to avoid a warning (#162).
    Put set_policy under cmake version test.
    Otherwise we get errors in older versions of cmake.
 -  Use VERSION_GREATER to clean up cmake version test.
 -  Improve afl target. Use afl-clang by default. Set default for path.

cmark 0.27.0
 jgm released this on 19 Nov 2016 揃 49 commits to master since this release

 -  Update spec to 0.27.
 -  Fix warnings building with MSVC on Windows (#165, Hugh Bellamy).
 -  Fix CMAKE_C_VISIBILITY_PRESET for cmake versions greater than 1.8
    (e.g. 3.6.2) (#162, Hugh Bellamy). This lets us build swift-cmark
    on Windows, using clang-cl.
 -  Fix for non-matching entities (#161, Yuki Izumi).
 -  Modified print_delimiters (commented out) so it compiles again.
 -  make format: don't change order of includes.
    Changed logic for null/eol checks (#160).
    * only check once for "not at end of line"
    * check for null before we check for newline characters (the
      previous patch would fail for NULL + CR)
 -  Fix by not advancing past both \0 and \n (Yuki Izumi).
 -  Add test for NUL-LF sequence (Yuki Izumi).
 -  Fix memory leak in list parsing (Yuki Izumi).
 -  Use cmark_mem to free where used to alloc (Yuki Izumi).
 -  Allow a shortcut link before a ( (commonmark/commonmark-spec#427).
 -  Allow tabs after setext header line (commonmark/commonmark.js#109).
 -  Don't let URI schemes start with spaces.
 -  Fixed h2..h6 HTML blocks (commonmark/commonmark-spec#430). Added regression test.
 -  Autolink scheme can contain digits (Gábor Csárdi)
 -  Fix nullary function declarations in cmark.h (Nick Wellnhofer).
 -  Fixes strict prototypes warnings.
 -  COPYING: Update file name and remove duplicate section and
     (Peter Eisentraut).
 -  Fix typo (Pavlo Kapyshin).
talum pushed a commit to github/cmark-gfm that referenced this issue Sep 14, 2021
@jgm
Fixed h2..h6 HTML blocks (commonmark/commonmark-spec#430).
e4d98b9 
Added regression test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgm @zzzzBov