Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonsApplication migrate to kotlin & some lint fixes #5879

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

CommonsApplication migrate to kotlin & some lint fixes #5879

wants to merge 7 commits into from

Conversation

parneet-guraya
Copy link
Contributor

From comment

What changes did you make and why?

  • Migrate application class to kotlin
  • some lint fixes

Tests performed (required)

tested betaDebug & prodDebug on Oneplus 9RT 5G , Android 14

@parneet-guraya
Copy link
Contributor Author

CI failing due to some unit test. Will fix it

@parneet-guraya parneet-guraya marked this pull request as draft October 21, 2024 01:02
@nicolas-raoul
Copy link
Member

I did a few uploads and tried most activities of the app with this branch. It works as usual. :-)

@parneet-guraya
Copy link
Contributor Author

Actually just one test failing due to lateinit instance property in application class, not being initialised while other tests do use that property and works fine :( . I'm a little rusty on testing, I will figure out what's causing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parneet-guraya @nicolas-raoul