Fixes issue #5841: Nearby pins: Make it easier to understand what the colors mean #5881
+116
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e5841_hannagnourt
nicolas-raoul
requested changes
Oct 21, 2024
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="0dp" | ||
| android:text="There is a Wikidata item here with no picture yet." |
There was a problem hiding this comment.
Would you mind making the text localizable?
See for instance android:text="@string/app_name" in app/src/main/res/layout/activity_about.xml
There was a problem hiding this comment.
Also, sorry to change the wording now, but I think this text would be more actionable for the user: This place has no picture yet, go take one!
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="0dp" | ||
| android:text="There is a Wikidata item with a picture here." |
There was a problem hiding this comment.
Wording: This place has a picture already
| android:id="@+id/textGrey" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="The app is checking if the Wikidata item here has a picture." |
There was a problem hiding this comment.
Wording: Now checking whether this place has a picture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5841
Tests performed (required)
Tested
prodDebugon Pixel 8 Pro with API level 35.Screenshots (for UI changes only)
nearby_legend.mp4