ENH: added sanity checks for compatibility with pyqtgraph #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello everyone. I've been using this patch since the original date of the PR with no issues whatsoever. Since it is a bunch of sanity checks, I believe we can merge this. Please review it. I believe it is beneficial to be able to use pyside2 with PythonQt! |
|
This looks fine to me, but wouldn't we want to suggest it to the upstream PythonQt? |
|
Sure, I'm on it! |
jamesobutler
pushed a commit
to jamesobutler/PythonQt
that referenced
this pull request
Dec 12, 2023
- also remove unneeded "pydebug.h" include -> fixes commontk#81
jcfr
pushed a commit
to jcfr/PythonQt
that referenced
this pull request
Dec 14, 2023
(adapted from commit MeVisLab/pythonqt@a93104d) - also remove unneeded "pydebug.h" include -> fixes commontk#81
jcfr
pushed a commit
that referenced
this pull request
Jan 28, 2024
(adapted from commit MeVisLab/pythonqt@a93104d) - also remove unneeded "pydebug.h" include -> fixes #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I've come back to this issue https://discourse.slicer.org/t/pythonqt-properties-shadowing-methods/16992
Turns out a GraphicsScene of pyqtgraph was referencing itself as a parent when wrapped by PythonQt. I don't know if it is a bug of pyqtgraph or PythonQt. All I know is that adding this simple sanity checks prevented stack overflows and now I have pretty pyqtgraphs integrated into a PythonQt app (3D Slicer) via wrapping a pythonqt layout with shiboken2 and adding a pyside2 widget to it. More details on referenced thread.
I don't know if it is a desirable merge but it is simple enough that I figured it could be of interest.