Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - Member portal - wrong time reported in event log when verifying with ccla #2655

Open
WillsonHG opened this issue Feb 16, 2021 · 12 comments
Assignees
Labels
bug Something isn't working CommunityReported Corporate Console for V2 Project Console V2 Project Console for EasyCLA V2 tier-3 An issue or feature that is considered a tier 3 priority issue v2

Comments

@WillsonHG
Copy link
Member

When a user is verifying under a company's ccla, the event log is recording the time the row for the signature was created in the signatures table instead of the time the user actually verified.

User hwccla verified at 11:01pm
image

Event log shows 10:54pm
image

Database shows that 10:54 was the time the row for the signature was created, not when the actual verification occurred.

image

@WillsonHG WillsonHG added bug Something isn't working v2 Corporate Console for V2 Project Console V2 Project Console for EasyCLA V2 labels Feb 16, 2021
@makkalot
Copy link
Contributor

makkalot commented Feb 16, 2021

The event that's pointed out is :

event_type=EventType.EmployeeSignatureCreated,
only records the signature creation not the signing. There should be another event there which is in form of A corporate signature was signed for project which should have the correct date. Maybe we should change the wording for the event that's saved on Signature creation ? @dealako

@makkalot makkalot self-assigned this Feb 16, 2021
@vinod-kadam vinod-kadam added the tier-3 An issue or feature that is considered a tier 3 priority issue label Feb 16, 2021
@nickmango
Copy link
Collaborator

@WillsonHG actually the time the user acknowledged(verified) being a part of the company is the same time the ecla record is actually created and the event is captured for that EventType.EmployeeSignatureCreated which should be the expected behavior.

@thakurveerendras
Copy link
Contributor

Hello @nickmango
The user-acknowledged activity log does not appear. Kindly review
image

@nickmango
Copy link
Collaborator

@thakurveerendras did you acknowledge via contributor console ? when affiliating to a company ?

@nickmango
Copy link
Collaborator

auto-ecla needs to be set to false for this to work

@mlehotskylf
Copy link
Contributor

@thakurveerendras to retest this.

@thakurveerendras
Copy link
Contributor

thakurveerendras commented Jul 3, 2024

@nickmango , Tested with SUN, Earth & Venus project and found that the user-acknowledged activity log is missing.

@mlehotskylf mlehotskylf assigned nickmango and unassigned makkalot Jul 11, 2024
@thakurveerendras
Copy link
Contributor

On the existing setup it is not working & Testing on the new setup is blocked by a PCC issue https://github.com/linuxfoundation/lfx-pcc/issues/2446

@thakurveerendras
Copy link
Contributor

@amolsontakke3576 Kindly review the PCC issue https://github.com/linuxfoundation/lfx-pcc/issues/2446 it blocked testing on easycla

@thakurveerendras
Copy link
Contributor

Hi @nickmango
Tested with new setup & found that The user-acknowledged activity log does not appear.

Kindly review the video clip: 2655.webm

nickmango added a commit to nickmango/easycla that referenced this issue Oct 13, 2024
- Resolved user acknowledgement event log

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Oct 13, 2024
@nickmango
Copy link
Collaborator

@thakurveerendras kindly verify this

@thakurveerendras
Copy link
Contributor

Checked activity log time for the event "acknowledged the CLA employee affiliation for company" and found that it is correct after fix on the dev site. So updating this issue status

Refer screenshot for more details
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CommunityReported Corporate Console for V2 Project Console V2 Project Console for EasyCLA V2 tier-3 An issue or feature that is considered a tier 3 priority issue v2
Projects
None yet
Development

No branches or pull requests

6 participants