Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC is not puling correctly the contributors list #4460

Open
2 of 15 tasks
jarias-lfx opened this issue Oct 25, 2024 · 9 comments
Open
2 of 15 tasks

PCC is not puling correctly the contributors list #4460

jarias-lfx opened this issue Oct 25, 2024 · 9 comments
Assignees
Labels
bug Something isn't working CommunityReported

Comments

@jarias-lfx
Copy link

Summary

PCC is not pulling the contributor lists correctly, while the CLA Corporate Console does

Background

Project Admins to CLA Project Admins need to see the contributor listing in PCC to confirm the authorization. It seems there is a bug in PCC that is not listing all the contributors correctly.

Expected behavior

PCC should list all contributors as the CLA Corporate Console

Screenshots

See how for Google and FOCUS we have the following contributor and is confirmed in the DB
image

While in PCC the user is no where to be foundÑ
image

Environment

Please complete the following information:

  • Environment:
    • ALL
    • DEV
    • STAGING
    • PROD
  • Browser:
    • Chrome/Brave
    • Firefox
    • Opera
    • Vivaldi
    • LibreWolf
    • SRware Iron
    • Dissenter
    • Slimjet
    • Midori
    • Edge
    • Lynx
  • Version: v1.0.XX
@jarias-lfx jarias-lfx added the bug Something isn't working label Oct 25, 2024
@mlehotskylf
Copy link
Contributor

This issue seem to be project specific because out test project in PROD is showing as expected in PCC.

@jarias-lfx
Copy link
Author

jarias-lfx commented Oct 28, 2024

@jarias-lfx
Copy link
Author

PCC Ticket: https://github.com/linuxfoundation/lfx-pcc/issues/2896

@nickmango
Copy link
Collaborator

nickmango commented Oct 29, 2024

This happens to be a frontend issue . Upon reviewing pagination is not being handled on the PCC UI . Backend is sending a nextKey that can be used to fetch the next items once page limit is exceeded as shown below
Initial call (returned count of 10 and total of 13 with next key value in the response)
Image

Second call
Image

nickmango added a commit to nickmango/easycla that referenced this issue Oct 29, 2024
- Fixed issue with pagesize greater than the total

Signed-off-by: Harold Wanyama <[email protected]>
@thakurveerendras
Copy link
Contributor

Hello @nickmango
CC: @amolsontakke3576

Please review the following backend cases that are reproducible. Frontend case is working fine and backend cases below are still reproducible.

  1. Wrong count appears, Refer below details
  • resultCount: 38
  • totalCount: 30
  1. Duplicate records listed under contributor

Refer screenshot for more details
image

nickmango added a commit that referenced this issue Oct 29, 2024
…gination

[#4460] Bug/Corporate Contributors API pagination
@nickmango
Copy link
Collaborator

Hello @nickmango CC: @amolsontakke3576

Please review the following backend cases that are reproducible. Frontend case is working fine and backend cases below are still reproducible.

  1. Wrong count appears, Refer below details
  • resultCount: 38
  • totalCount: 30
  1. Duplicate records listed under contributor

Refer screenshot for more details image

@thakurveerendras frontend needed to work on pagination. This explains why its working on corporate console but not PCC. Duplicate issue is another issue to fix however will work on that

nickmango added a commit to nickmango/easycla that referenced this issue Oct 29, 2024
- Removed duplicates for corporate contributors

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Oct 29, 2024
nickmango added a commit that referenced this issue Oct 30, 2024
…a-duplicates

Revert "[#4460] Feature/Corporate contributors dups"
@nickmango
Copy link
Collaborator

The PCC count of 30 is accurate and confirmed by the db records (An extra filter is used on PCC to ensure eclas are both signed and approved)
Image
For the corporate console (both authorized and non authorized users are returned) explaining a total score of 38
Image

nickmango added a commit to nickmango/easycla that referenced this issue Nov 4, 2024
- Fixed issue with pagesize greater than the total

Signed-off-by: Harold Wanyama <[email protected]>
@thakurveerendras
Copy link
Contributor

Agree with you @nickmango

Updating this issue status by referring above comment, I will add a separate ticket for duplicate records issue if replicated on production after deployment of this issue changes

@thakurveerendras
Copy link
Contributor

Tested the fix on production and found that it is working fine. So updating this ticket status

Refer to the screenshot
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CommunityReported
Projects
None yet
Development

No branches or pull requests

5 participants