feat/py312-compatibility #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't request a review, tagging @JelleZijlstra |
|
also have confirmed this works on x86 debian image and my m1 mac, probs would be worthwhile to add in some tests tho |
|
The change looks good; the library doesn't seem to use typed-ast anywhere. Could you also update tests.yml to run tests on 3.12 too? And maybe 3.13-dev as well while we're here. |
|
yup taking a look here |
billy-doyle
force-pushed
the
feat/py312-compatability
branch
from
64eb0e8
to
f7c5a17
Compare
|
No CI again here, let me close and reopen to see if that helps |
|
name change in the file :) |
|
lmk if ya want a rebase or anything |
| @@ -5,20 +5,20 @@ on: | |||
| branches: | |||
| - master | |||
| paths: | |||
| - ".github/workflows/test.yml" | |||
| - ".github/workflows/tests.yml" | |||
JelleZijlstra
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in multiple issues, but notably mingrammer#832 (comment), remove typed-ast for 3.12 compatibility