Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Fields in Arguments #186

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Abstract Fields in Arguments #186

merged 8 commits into from
Jun 21, 2024

Conversation

willtebbutt
Copy link
Member

Addresses #184

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Performance Ratio:
Warning: results are very approximate!

┌────────────────────────────┬────────┬─────────┬─────────────┬─────────┐
│                      Label │  Tapir │  Zygote │ ReverseDiff │  Enzyme │
│                     String │ String │  String │      String │  String │
├────────────────────────────┼────────┼─────────┼─────────────┼─────────┤
│                        sum │   35.0 │   0.324 │        2.35 │   0.486 │
│                       _sum │   6.76 │   505.0 │        26.6 │   0.121 │
│                   kron_sum │   85.0 │    3.51 │       219.0 │    24.1 │
│              kron_view_sum │   97.8 │    11.4 │       255.0 │    8.66 │
│      naive_map_sin_cos_exp │   4.12 │ missing │        8.98 │     2.8 │
│            map_sin_cos_exp │   4.76 │    1.79 │        7.56 │     3.4 │
│      broadcast_sin_cos_exp │   4.49 │    2.66 │        1.69 │    2.86 │
│                 simple_mlp │   8.79 │    3.09 │        11.3 │    3.15 │
│                     gp_lml │   15.2 │    4.31 │     missing │ missing │
│ turing_broadcast_benchmark │   8.91 │ missing │        28.7 │ missing │
└────────────────────────────┴────────┴─────────┴─────────────┴─────────┘

@willtebbutt
Copy link
Member Author

willtebbutt commented Jun 20, 2024

Hope fully the latest commits fix the issue with the Turing.jl integration testing. This should not be merged yet though, because I need to add a unit test which captures the behaviour that was causing the Turing.jl integration test to fail.

It's mildly awkward to add a unit test for this, and this code is unlikely to regress. If we find the problem that I found half way through this PR in a future PR, we'll add a unit test there. I'll merge when CI passes.

@willtebbutt willtebbutt merged commit 9ca0554 into main Jun 21, 2024
16 checks passed
@willtebbutt willtebbutt deleted the wct/argument-extraction branch June 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant