Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(process): compio-process #224

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

Berrysoft
Copy link
Member

This PR adds a new crate, compio-process.

  • Windows: driver is modified to accept APC routines. This is required for anonymous pipes to child process.
  • Linux: tries to create a pidfd. If failed, fallback to spawn_blocking.

@Berrysoft Berrysoft self-assigned this Mar 8, 2024
@Berrysoft Berrysoft added the enhancement New feature or request label Mar 8, 2024
@Berrysoft Berrysoft marked this pull request as draft March 8, 2024 16:53
@Berrysoft Berrysoft marked this pull request as ready for review March 8, 2024 17:05
@Berrysoft Berrysoft marked this pull request as draft March 24, 2024 16:42
@Berrysoft Berrysoft marked this pull request as ready for review March 24, 2024 16:53
@Berrysoft Berrysoft force-pushed the dev/process branch 2 times, most recently from 0c6fb1a to 9a2a434 Compare April 9, 2024 11:17
@Berrysoft Berrysoft force-pushed the dev/process branch 2 times, most recently from a9485c1 to 89adb8a Compare April 30, 2024 18:25
@George-Miao
Copy link
Member

Please split the PR into two, one for parameterizing SharedFd, one for compio-process

@Berrysoft Berrysoft force-pushed the dev/process branch 2 times, most recently from 8dd189d to cfe1708 Compare May 2, 2024 08:45
@Berrysoft Berrysoft force-pushed the dev/process branch 2 times, most recently from e3e0b2e to 7a6a0e6 Compare May 27, 2024 18:07
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 456b47b into compio-rs:master May 31, 2024
29 checks passed
@Berrysoft Berrysoft deleted the dev/process branch May 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants