-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(process): compio-process #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berrysoft
force-pushed
the
dev/process
branch
2 times, most recently
from
April 9, 2024 11:17
0c6fb1a
to
9a2a434
Compare
Berrysoft
force-pushed
the
dev/process
branch
2 times, most recently
from
April 30, 2024 18:25
a9485c1
to
89adb8a
Compare
Please split the PR into two, one for parameterizing |
Berrysoft
force-pushed
the
dev/process
branch
2 times, most recently
from
May 2, 2024 08:45
8dd189d
to
cfe1708
Compare
George-Miao
reviewed
May 13, 2024
George-Miao
reviewed
May 13, 2024
Berrysoft
force-pushed
the
dev/process
branch
2 times, most recently
from
May 27, 2024 18:07
e3e0b2e
to
7a6a0e6
Compare
On Linux, it tries to use pidfd with nightly feature enabled, otherwise, it uses spawn_blocking.
George-Miao
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new crate,
compio-process
.spawn_blocking
.